Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cache-control: no-cache behavior is wrong #52

Open
a-luna opened this issue Jul 7, 2021 · 1 comment
Open

cache-control: no-cache behavior is wrong #52

a-luna opened this issue Jul 7, 2021 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@a-luna
Copy link
Owner

a-luna commented Jul 7, 2021

per MDN, the HTTP 1.1 spec, and every other authoritative resource on this subject, the cache-control no-cache directive is NOT used to indicate that a response should not be cached.

This is rather unintuitive, but I probably should have known this before I went and built a caching plugin for FastAPI. I need to figure out exactly how to fix this, which will probably reveal even more places where I have violated the most basic of caching rules.

@a-luna a-luna added the bug Something isn't working label Jul 7, 2021
@a-luna a-luna self-assigned this Jul 7, 2021
@ionutbaltariu
Copy link

ionutbaltariu commented Jul 1, 2022

Hello!
Any progress on this issue?
In my case it seems that the cache-control: no-cache|no-store header is simply ignored by fastapi-redis-cache, resulting in caching with an expiry period of 60 seconds.

My opinion that the cache-control: no-cache situation should be left for implementation for the users of the library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants