Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comments #51

Open
g-sam opened this issue Dec 1, 2016 · 3 comments
Open

Comments #51

g-sam opened this issue Dec 1, 2016 · 3 comments

Comments

@g-sam
Copy link

g-sam commented Dec 1, 2016

Some comments.

  • This should be POST. See here.
  • Use template literals to construct multiline strings e.g. here.
  • Can you do this with one query? If not, please make an issue explaining why.
  • Apply this filter in the query.
  • This should be one query (see e.g. here).

Looks really good!

@tbtommyb
Copy link
Contributor

tbtommyb commented Dec 2, 2016

I will make a start now on the last point.

@Cleop
Copy link
Contributor

Cleop commented Dec 2, 2016

I'll do the 2nd bullet point.
Tom is now working on the 2nd from last.

@tbtommyb tbtommyb mentioned this issue Dec 2, 2016
@tbtommyb
Copy link
Contributor

tbtommyb commented Dec 2, 2016

PR #67 fixes the bottom two, looking at the 3rd bullet point now. The link is broken as we changed the code but I think it refers to having two separate queries for getting all resources and all reviewed resources.

@Cleop Cleop mentioned this issue Dec 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants