Skip to content
This repository has been archived by the owner on Jun 1, 2024. It is now read-only.

Checking of Start Year and Current year and Config.json #15

Open
hectorcustodiozup opened this issue Jan 25, 2022 · 1 comment
Open

Comments

@hectorcustodiozup
Copy link

Currently it seems that the license header looks for two year validation Line of code. The Start Year and the Current Year, is this behavior the mandatory? or is there a reason to be so? I am asking because every time it runs the validation sometimes it breaks only because the current year is not found, it requires changes on the Header of older files which have already been validated in later commits.

A second issue would be the name of the configuration file config.json

const configFile = "config.json"
which maybe is not very intuitive for its purpose and for new users of the projects implementing the action.

@thallesfreitaszup
Copy link
Contributor

thallesfreitaszup commented Jan 28, 2022

hey @hectorcustodiozup after see the issue i think it can not be mandatory as a lot of projects do not use this as pattern.We will talk in the next week about that and return some options so we can discuss with you. Thanks for the contribution

About the configuration file, i agree that is not very intuitive. Do you think that license.json is a better name? or that the user could specify the config file?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants