Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FeatureRequest] Please add weather providers like DarkSky #42

Open
ciriousjoker opened this issue Sep 30, 2018 · 4 comments
Open

[FeatureRequest] Please add weather providers like DarkSky #42

ciriousjoker opened this issue Sep 30, 2018 · 4 comments

Comments

@ciriousjoker
Copy link

(title says it all)

@hsantanna
Copy link

Here is the API Docs: https://darksky.net/dev/docs

But the use seems to be paid (1000 requests per day are free to use).
This probably implies that each user needs to create their own developer key to use in the widget.

@njakes
Copy link

njakes commented Jun 22, 2020

How easy is it to swap out the DarkSky API information? I live in an area not covered by OpenWeather but is covered very well by DarkSky.
Is it in OpenWeatherMap.js?

@Zren
Copy link
Owner

Zren commented Jun 22, 2020

Note: DarkSky has been aquired by Apple and is shutting down service in 2021.

https://blog.darksky.net/


While you could modify OpenWeatherMap.js, I assume the code change would be rather complex.

I'd recommend creating a code/DarkSky.js, then modify code/WeatherApi.js to account for if (weatherService == 'DarkSky'). Then change the default weather_service in config/main.xml to <default>DarkSky</default>.

Focus on using a hardcoded api key and city id in DarkSky.js until you get it working. Use plasmawindowed org.kde.plasma.eventcalendar to quickly test.

@njakes
Copy link

njakes commented Jun 22, 2020

Thank you so much for that detailed response. I didnt realize they had been bought out. Yr.no works well for me too so perhaps I will look into doing it with them too. I have next to no coding knowledge, we'll see how it goes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants