Disable ExecUtil tests. Mention wrapToken probably isn't hardened.

Zren · Zren · commit 5625282462a1 · 2019-11-02T10:04:54.000-04:00
diff --git a/package/contents/ui/lib/ExecUtil.qml b/package/contents/ui/lib/ExecUtil.qml
@@ -29,7 +29,8 @@ PlasmaCore.DataSource {
 
 	property var listeners: ({}) // Empty Map
 
-	// Note that this is not tested.
+	// Note that this has not gone under a security audit.
+	// You probably shouldn't trust 3rd party input.
 	function wrapToken(token) {
 		token = "" + token
 		// ' => '"'"' to escape the single quotes
@@ -67,5 +68,5 @@ PlasmaCore.DataSource {
 		exec(['notify-send', 'test', '\'; notify-send escape3;\''])
 		exec(['notify-send', 'test', '\\\'; notify-send escape4;\\\''])
 	}
-	Component.onCompleted: test()
+	// Component.onCompleted: test()
 }

Original file line number	Diff line number	Diff line change
`@@ -29,7 +29,8 @@ PlasmaCore.DataSource {`
`29`	`29`
`30`	`30`	`property var listeners: ({}) // Empty Map`
`31`	`31`
`32`		`- // Note that this is not tested.`
	`32`	`+ // Note that this has not gone under a security audit.`
	`33`	`+ // You probably shouldn't trust 3rd party input.`
`33`	`34`	`function wrapToken(token) {`
`34`	`35`	`token = "" + token`
`35`	`36`	`// ' => '"'"' to escape the single quotes`
`@@ -67,5 +68,5 @@ PlasmaCore.DataSource {`
`67`	`68`	`exec(['notify-send', 'test', '\'; notify-send escape3;\''])`
`68`	`69`	`exec(['notify-send', 'test', '\\\'; notify-send escape4;\\\''])`
`69`	`70`	`}`
`70`		`- Component.onCompleted: test()`
	`71`	`+ // Component.onCompleted: test()`
`71`	`72`	`}`