Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thaumometer related crash. #91

Open
DaRetroCat opened this issue Sep 9, 2022 · 2 comments
Open

Thaumometer related crash. #91

DaRetroCat opened this issue Sep 9, 2022 · 2 comments
Labels
Bug Something isn't working

Comments

@DaRetroCat
Copy link

Describe the bug
Using the thaumometer on certain mobs causes a client crash.

To Reproduce
Steps to reproduce the behavior:

  1. Hold the thaumometer.
  2. Look at either a thaumcraft golem or a firebat.
  3. Crash.

Expected behavior
Seeing the entity's aspects similar to other mobs.

Additional context
This was tested with only Baubles, JEI, Planar Artifice, and Thaumcraft loaded.
Full crash report: https://pastebin.com/iCZmHVpa

@DaRetroCat DaRetroCat added the Bug Something isn't working label Sep 9, 2022
@KatTheFox
Copy link

KatTheFox commented Dec 9, 2023

I'm also having this issue- and it's almost certainly related to these lines:

set("thaumcraft:golem", getRaw("Thaumcraft.Golem").add("imperium", 10));

set("thaumcraft:firebat", getRaw("Thaumcraft.Firebat").add("infernum", 10));

Adding an aspect (in this case, imperium to golems and infernum to firebats) that does not exist would definitely cause issues. If you add Thaumic Additions (the mod that adds imperium and infernum), the crash should resolve itself.
Either mark Thaumic Additions Reconstructed as a hard dependency, or add a check for whether it's loaded. That'll fix the crash.

@KatTheFox
Copy link

The same issue is present for Blaze, Ghast, Magma Cube, Zombie Pigman, and the Ender Dragon. Several items have the same issue, but it looks like thaumcraft may handle that more gracefully. Either way, add a check for whether a mod is loaded before you try to use its content, always. Honestly I have no idea how this bug wasn't caught sooner, unless you always play with all the optional dependencies enabled.

KatTheFox added a commit to KatTheFox/planar-artifice that referenced this issue Dec 9, 2023
@KatTheFox KatTheFox mentioned this issue Dec 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants