feat(gcp_sqs_config): adds support for min and max replicas #891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #891 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 142 142
Lines 6100 6100
=========================================
Hits 6100 6100 ☔ View full report in Codecov by Sentry. |
supersergiy
reviewed
Feb 6, 2025
| configuration, _ = get_cluster_data(cluster_info) | ||
| with secrets_ctx_mngr(run_id, secrets, cluster_info, namespace=namespace): | ||
| manifest = _get_scaled_job_manifest( | ||
| f"{run_id}-{group_name}", | ||
| [_get_sqs_trigger(sqs_trigger_name, queue)], | ||
| job_spec=job_spec, | ||
| min_replicas=replicas, |
There was a problem hiding this comment.
Does the deployment start with min replicas or max replicas?
There was a problem hiding this comment.
I don't think we would ever want a deployment that cannot scale to 0, so I would guess min replicas should always be 0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.