Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: misalignment augmentation #611

Closed
wants to merge 8 commits into from

Conversation

supersergiy
Copy link
Member

No description provided.

@supersergiy supersergiy requested a review from torms3 January 16, 2024 07:53
Copy link

codecov bot commented Jan 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (6fb9ebf) to head (efaf14f).
Report is 954 commits behind head on main.

Current head efaf14f differs from pull request most recent head 2fb71c5

Please upload reports for the commit 2fb71c5 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##              main      #611    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files          128       135     +7     
  Lines         4550      4864   +314     
==========================================
+ Hits          4550      4864   +314     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@supersergiy supersergiy force-pushed the sergiy/misalignment_augmentation branch from 56d413d to 58f7c91 Compare February 1, 2024 23:03
@supersergiy supersergiy force-pushed the sergiy/misalignment_augmentation branch from 58f7c91 to 66dd746 Compare February 2, 2024 12:44
@supersergiy supersergiy requested a review from torms3 March 11, 2024 03:05
@supersergiy supersergiy force-pushed the sergiy/misalignment_augmentation branch from 7f6eac0 to 8ffcb3c Compare May 7, 2024 14:05
if self.disp_in_unit_must_be_divisible_by is None and not all(
e[0:2] == sizes[0][0:2] for e in sizes
):
raise ValueError(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't fully understand this constraint. The composition of misalignment augmentation is widely used, and misalignment augmentation can always make the volumetric index non-square.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants