Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GKE command #598

Merged
merged 2 commits into from
Jan 3, 2024
Merged

Update GKE command #598

merged 2 commits into from
Jan 3, 2024

Conversation

nkemnitz
Copy link
Collaborator

@nkemnitz nkemnitz commented Jan 3, 2024

  • replaces the default service account using --scopes with our workload identity service account. (Caused issues with DDP at some point, I believe)
  • remove duplicate --num-nodes entries
  • use latest GPU driver daemonset by default. Required for using L4 and other newer GPU, and recently also a Pytorch 2.1 issue @torms3 ran into.

@nkemnitz nkemnitz added the infra label Jan 3, 2024
Copy link

codecov bot commented Jan 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5d78841) 100.00% compared to head (9949c72) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #598   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          128       128           
  Lines         4433      4433           
=========================================
  Hits          4433      4433           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@supersergiy supersergiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@supersergiy supersergiy merged commit 42cf73b into main Jan 3, 2024
11 checks passed
@nkemnitz nkemnitz deleted the nkem/update-gke-command branch January 3, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants