Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deduplication logic #595

Closed
3 of 4 tasks
nkemnitz opened this issue Dec 29, 2023 · 0 comments · Fixed by #602
Closed
3 of 4 tasks

Fix deduplication logic #595

nkemnitz opened this issue Dec 29, 2023 · 0 comments · Fixed by #602
Assignees
Labels
bug Something isn't working

Comments

@nkemnitz
Copy link
Collaborator

nkemnitz commented Dec 29, 2023

#593 + #594 fixed an incorrect deduplication, but there are several unnecessary deduplications now.

Todo:

  • Test needs to run these hashes twice, in separate Python processes, and ensure they match across sessions
  • Fix the unnecessary deduplication for ClassD1().method and ClassD2().method

Maybe:

  • Add performance measurement
  • Dill?

Current behavior for two separate runs of test_id_generation (which should return the same hash):

test_generate_invocation_id_method()
c5c763f586c6ac82e8ca7925d305fdc3    c5c763f586c6ac82e8ca7925d305fdc3
577511d6e755f310b91118c124890381    577511d6e755f310b91118c124890381
577511d6e755f310b91118c124890381    577511d6e755f310b91118c124890381
1b7683bf49cd2f37e93f93cea76b11dd    1b7683bf49cd2f37e93f93cea76b11dd
29960dc7a3b33c78dda58cae6e1401d8    29960dc7a3b33c78dda58cae6e1401d8
29960dc7a3b33c78dda58cae6e1401d8    29960dc7a3b33c78dda58cae6e1401d8
e97dbab4b49a1f195178c9ea728e5ad3    e97dbab4b49a1f195178c9ea728e5ad3
e97dbab4b49a1f195178c9ea728e5ad3    e97dbab4b49a1f195178c9ea728e5ad3
29960dc7a3b33c78dda58cae6e1401d8    29960dc7a3b33c78dda58cae6e1401d8
17d8f0f90bf04d5fa84b30de55d44e20    17d8f0f90bf04d5fa84b30de55d44e20
e97dbab4b49a1f195178c9ea728e5ad3    e97dbab4b49a1f195178c9ea728e5ad3
4e42a4fca5e49297d4f5020593aba10e    4e42a4fca5e49297d4f5020593aba10e
2725b4bd1fc9957f8e9672c6969ae3e8    a0e4bc888166b7d9df4693583adf2c06 <--
c6372734d3e7dad8561d0d01913d4604    40540a850846d398418faa932bd2e507 <--
3a037b37736c951d062641a01b9a7d8a    a1e7a11351d9a3493f683bc22672d861 <--
1d6f803f26b2c05b57fe1abef23bb390    b2818c6e93a19a55c1a5735c024c696a <--

test_generate_invocation_id_partial()
0ee5e000d8260ce0e710af243e15ab9b    0ee5e000d8260ce0e710af243e15ab9b
239126230233e3fdeedf00dc7cc689dc    239126230233e3fdeedf00dc7cc689dc
239126230233e3fdeedf00dc7cc689dc    239126230233e3fdeedf00dc7cc689dc
7d2f36bb86776dd2a41bbe266d091063    7d2f36bb86776dd2a41bbe266d091063
c5547b85d0bcef9e48938029e7b63106    c5547b85d0bcef9e48938029e7b63106
c5547b85d0bcef9e48938029e7b63106    c5547b85d0bcef9e48938029e7b63106
1be8b00c88922fd270b8bf09c892d94a    1be8b00c88922fd270b8bf09c892d94a
1be8b00c88922fd270b8bf09c892d94a    1be8b00c88922fd270b8bf09c892d94a
c5547b85d0bcef9e48938029e7b63106    c5547b85d0bcef9e48938029e7b63106
0f7be8c2e0615dc336c83406f29065d8    0f7be8c2e0615dc336c83406f29065d8
1be8b00c88922fd270b8bf09c892d94a    1be8b00c88922fd270b8bf09c892d94a
15d78e1f3009c88a0f173341d1da220a    15d78e1f3009c88a0f173341d1da220a
eee20dcc0583b60358c91f6bd0d8c817    ee3438902cd82b28061aebf0c3dd5ebf <--
d57709256f0109013b4f90ea30b8e336    a17618d53ae1054e4b141fdf9e927790 <--
767caa3a7e73dd372aed883a46bafe83    34a911740b1c2a686210d8f6c158e282 <--
7127588398b3bea639ac8078b3ad234e    f31acb5d30542bff467b402ecf9ba069 <--

test_generate_invocation_id_taskable_op()
d6cecf77790f695640d5e238a37356ec    d6cecf77790f695640d5e238a37356ec
f95b654be5c723e8de0a7517cfd869b6    f95b654be5c723e8de0a7517cfd869b6
f95b654be5c723e8de0a7517cfd869b6    f95b654be5c723e8de0a7517cfd869b6
e9d31341553ad09d8bb0487a200215d5    e9d31341553ad09d8bb0487a200215d5
34cf3c186e8808b514ee36b0de2cba96    34cf3c186e8808b514ee36b0de2cba96
34cf3c186e8808b514ee36b0de2cba96    34cf3c186e8808b514ee36b0de2cba96
82cb0ae4b130dc3e911413c23c0fa925    82cb0ae4b130dc3e911413c23c0fa925
82cb0ae4b130dc3e911413c23c0fa925    82cb0ae4b130dc3e911413c23c0fa925
34cf3c186e8808b514ee36b0de2cba96    34cf3c186e8808b514ee36b0de2cba96
ee3e256196fa3f633670efea4c99986f    ee3e256196fa3f633670efea4c99986f
82cb0ae4b130dc3e911413c23c0fa925    82cb0ae4b130dc3e911413c23c0fa925
59ee02f87eec768de57ede0c00127f2f    59ee02f87eec768de57ede0c00127f2f
1b65870f3adcd9f2e9bdcc369a88656c    1b65870f3adcd9f2e9bdcc369a88656c
1b65870f3adcd9f2e9bdcc369a88656c    1b65870f3adcd9f2e9bdcc369a88656c
1b65870f3adcd9f2e9bdcc369a88656c    1b65870f3adcd9f2e9bdcc369a88656c
61536de778b4cf4031b4762364d06bca    61536de778b4cf4031b4762364d06bca

test_generate_invocation_id_flow_schema()
4f2bc9c6be99eb1bfe4bf8d6ceb8b643    583e57ff86be3081fbc2c7d58e29b31b <--
d874ab4352cf77e111fa2cec24bdfef6    f49bf4b6114654ec523288c9bfdce5aa <--
d874ab4352cf77e111fa2cec24bdfef6    f49bf4b6114654ec523288c9bfdce5aa <--
fc788d5a050bdd20ce18b15bea5b2ac3    fff35225ca545b522bb56722a9d4e4e3 <--
11a0d6dd419b2dd3feb8c84e9b58cd3e    99edeca2cc97b2dc26ef18bc5146f3c1 <--
11a0d6dd419b2dd3feb8c84e9b58cd3e    99edeca2cc97b2dc26ef18bc5146f3c1 <--
46945a1d6d019ee5ace9522263d8f63b    002a620d4af7b3d56a66ab6489f38500 <--
46945a1d6d019ee5ace9522263d8f63b    002a620d4af7b3d56a66ab6489f38500 <--
11a0d6dd419b2dd3feb8c84e9b58cd3e    99edeca2cc97b2dc26ef18bc5146f3c1 <--
e8f7300e2a26aae394781b83448734c2    2c4eae31234e8c474f1997ce00405370 <--
46945a1d6d019ee5ace9522263d8f63b    002a620d4af7b3d56a66ab6489f38500 <--
c12578a5b6dee318821c0e450d614442    388572b53c770dcaa386d51a2bad5dd1 <--
8fdf03ab309aea308af8070bc55b3f44    9812ea9ee4ddb63330c6f6a2dc8a483e <--
fcb89c6cef874c7cc5c4c9ebbad19431    a7015e56e1a9c15f5234d034ece5328d <--
62eeaec38e751ddaf1b1068b957fa30f    3f84dd7aa86f77aeedfd628b280dfddb <--
1604127f655a9a9955d40d06c5618efd    9401748d5884d2516b36a970c260ddac <--
@nkemnitz nkemnitz added the bug Something isn't working label Dec 29, 2023
@nkemnitz nkemnitz self-assigned this Dec 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant