Track and resolve technical debt towards MVP

[thesethtruth]

Technical integration:

• Database items have string elements that are not validated: interactive elements has etm_key & factor table has asset_attribute #248
• Move the hard-coded local configs of modules to the CMS #249
• Implement tests using the Django test suite #250

Preprocessor

• Most manipulation of the cloudclient.datamodel is being done on the json or dict version: that should be mostly done on the data model instead to ensure correct fields and types #244
• All policies are being parsed based on the fact that they can't be parsed to a float, assumes that all strings are policies which are solve using a very manual solution #245
• Asset (attribute) adjusting sliders are applied with a nasty nested loop #246
• There is no way of implementing contract logic from the CMS, but is programmed in the backend #247
• Setting new assets / settings should be able to balance a group #255

Cloudclient

• Total cheeser of an import for the datamodel definition using sys.path.append and importlib #237
• cloudclient_init script command does some idiotic pathing magic based in part on the .clouclient-location.yml (example) #238
• Uses Pydantic to describe datamodels, should this at a certain point move to a Django model? #239
• NonFirmActor implements behaviour that should actually be part of a certain contract? #240
• charging_mode, battery_mode are implemented in the grid connection but should be part of the actor or asset? Same for the nfATO settings #241
• VehicleConversionAsset implemented for fossil vehicles but is it really best suited to conversionAssets? #242
• The keys that actually should be foreign (e.g. gridconnection_id or owner_agent) are now just unvalidated strings. Check validity at runtime or make foreign keys? #251

Economic module

• No validation of inputs and compatibilty between them #252
• If costs can't be found in ETM output, use 0 instead of raising something meaningful (please not silently) #253
• Tighten bonds to datamodel instead of accepting only JSON style format nf-ATO and behaviour #254

ETM scaling

• Combine convert and balance for upscaling to avoid looping over requests twice #256
• Better documentation of data types #257
• Balancer should not distribute losses over untouched sliders HOLON-ETM#16
• Balancer should balance based on how sliders were already set (currently most of the 'real' balancing is removed in favour of hard coding it for the KEV scenario) HOLON-ETM#15
• Sending batches to SET actions should not rely on generators #260
• Add more endpoints and converters as necessary for next cases HOLON-ETM#20
• Attach to Datamodel and to-be-built ETM CMS settings instead of all these config YAMLS #262
• Move to ETM pro instead of beta #263
• Caching of 'more or less' static results from ETM (cost numbers, etc.) #264
• Caching of basic ETM scenario info #265
• Make it possible to combine GET and SET actions for less requests to ETM (for upscaling + getting KPIs) #266
• ETM-upscaling: Zero value is not accepted for electric trucks? HOLON-ETM#17

[thesethtruth]

With model team:

• add DIESEL_VEHICLE to Assets options for both factor and interactive elements @mattijsstam @thesethtruth
• Policies from interactive sliders?? @thesethtruth @mattijsstam
• Update datamodel mvp.py with new model config (place defaults in a mpv_defaults.py file)
• Check ETM upscaling with @noracato
• Add functionality to parse policies from interactive elements @thesethtruth
• Sanity on cost module (im_sorry.py) @JorritvandenHouten
• Mock the ETM outputs using https://github.com/ZEnMo/HOLON-ETM and formulate the post processing features for pepe
  • Sustainability (percentage)
  • Selfsufficiency (import export balans)
  • Net load (percentage station capacity at peakload, greater than capacity)

[thesethtruth]

#236

[Erikvv]

Niet meer relevant