fix(docs): Fix NU6-related documentation #8949
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We want to update the documentation around NU6 funding streams now that draft funding allocation ZIP has been assigned a ZIP number.
We also want to avoid the panics listed as examples in the audit report that could arise from incorrect network parameters.
Note that there are many more potential panics that could be triggered with incorrect network parameters, and ideally those (and many other panics in Zebra) could be replaced with errors, but this should be done when cleaning up tech debt. Leaving these panics should be okay for now, as the hard-coded Mainnet and Testnet parameters have been manually verified, any configured Testnet parameters should be validated when parsing the Zebra's configuration, and avoiding panics in these cases would still leave Zebra unable to correctly validate blocks and transactions, so the benefit of replacing them with errors is limited.
Closes #8903.
Part of #8904.
Solution
Related fixes:
subsidy_is_valid()
related to using the correct slow start interval on configured TestnetsFollow-up Work
Replace other panics in Zebra where it would be better to return an error.
PR Author's Checklist
PR Reviewer's Checklist