Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't render external images referenced by user-submitted content #451

Open
tromer opened this issue Jun 2, 2019 · 1 comment
Open

Don't render external images referenced by user-submitted content #451

tromer opened this issue Jun 2, 2019 · 1 comment

Comments

@tromer
Copy link

tromer commented Jun 2, 2019

The system currently allows <img a="..."> rendering of images stored in external websites. For example, https://grants.zfnd.org/proposals/575713843-zcash-sapling-offline-paperwallet-generatator automatically renders the image at https://raw.githubusercontent.com/ZcashFoundation/zecwallet/master/res/images/sapling%20paper.png.

This is bad website hygiene, for several reasons:

  • It broadcasts the IP addresses and browser metadata of grant system users to those external websites, harming their privacy. (This is especially significant with anonymous money donations on the line.)
  • The images may change externally, meaning for example that important parts of proposal could be retroactively changed without any records kept.
  • Such images are a potential attack vector on users' browsers, and if they're external, filtering and forensics are infeasible.

This may also apply to other user-generated content, such as discussion comments.

@dternyak
Copy link
Collaborator

dternyak commented Jun 3, 2019

Hey @tromer,

Thanks for bringing this up! We'll discuss internally as to next steps. ZF Grants has extensive moderation tools in place to assist with taking down offensive UGC should images be changed after approval, but you bring up some great points nonetheless.

Greatly appreciate your time and input on this and the other issues you've opened 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants