diff --git a/.idea/codeStyles/Project.xml b/.idea/codeStyles/Project.xml index 34dc27c..a9ea262 100644 --- a/.idea/codeStyles/Project.xml +++ b/.idea/codeStyles/Project.xml @@ -3,6 +3,9 @@ + + - + diff --git a/README.md b/README.md index 873911c..dd4456e 100644 --- a/README.md +++ b/README.md @@ -1,5 +1,18 @@ # ArtGallery -A sample android app +A sample android app that shows how to use ViewModels and Room together with RxJava, in Kotlin by Clean Architecture. + +### Implemented by Clean Architecture +The following diagram shows the structure of this project with 3 layers: +- Presentation +- Domain +- Data + +
+

+ +

+
+ ### Scenario Used https://jsonplaceholder.typicode.com/ as a public api to generate fake data for testing @@ -10,7 +23,7 @@ At a glance: - In the Item of each Album, showed user name. - When user taps on Album, new page will be shown which includes list of photos. - when user taps on photo, show image bigger through transition. -- Were Written tests to completely cover Exceptions/Expectations(Not yet) +- Were Written tests to completely cover Exceptions/Expectations - And: - Supported orientation change - Supported offline mode \ No newline at end of file diff --git a/app/build.gradle b/app/build.gradle index 1be7e7c..d21e7f0 100644 --- a/app/build.gradle +++ b/app/build.gradle @@ -64,7 +64,6 @@ dependencies { implementation 'com.squareup.picasso:picasso:2.71828' implementation 'com.android.support:design:28.0.0' implementation 'com.android.support:multidex:1.0.3' - testImplementation 'junit:junit:4.12' androidTestImplementation 'com.android.support.test:runner:1.0.2' androidTestImplementation 'com.android.support.test.espresso:espresso-core:3.0.2' diff --git a/app/src/androidTest/java/com/android/artgallery/data/PhotoDaoTest.kt b/app/src/androidTest/java/com/android/artgallery/data/PhotoDaoTest.kt index d09a600..7d9057f 100644 --- a/app/src/androidTest/java/com/android/artgallery/data/PhotoDaoTest.kt +++ b/app/src/androidTest/java/com/android/artgallery/data/PhotoDaoTest.kt @@ -33,6 +33,12 @@ class PhotoDaoTest { mDatabase.close() } + @Test + @Throws(Exception::class) + fun isPhotoListEmpty(){ + assertEquals(0,mDatabase.photoDao.loadAll().size) + } + @Test @Throws(Exception::class) diff --git a/diagram.png b/diagram.png new file mode 100644 index 0000000..e05711d Binary files /dev/null and b/diagram.png differ