You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
.ok_or(Error::InvalidEvalDomainSize {
log_size_of_group: plonk_verifier_key.n.trailing_zeros(),
adacity: <F as FftField>::FftParams::TWO_ADACITY,
})?
instead of unwrap() but I'm having some issues implementing this.
I could just remove the parameters from InvalidEvalDomainSize or something quick, or leave it as unwrap and open another issue/PR for this case (since it's rather independent)
I eventually added some workaround, but I think it could use some additional work. Maybe the GeneralEvaluationDomain can be constructed in one place instead of the several places it is now.
Also it might be better if GeneralEvaluationDomain::new returns a Result instead of an Option, not sure about that.
We should do something like:
instead of
unwrap()
but I'm having some issues implementing this.I could just remove the parameters from
InvalidEvalDomainSize
or something quick, or leave it asunwrap
and open another issue/PR for this case (since it's rather independent)Originally posted by @joebebel in #61 (comment)
The text was updated successfully, but these errors were encountered: