Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the Witness Table #136

Open
LukePearson1 opened this issue Apr 25, 2022 · 0 comments
Open

Remove the Witness Table #136

LukePearson1 opened this issue Apr 25, 2022 · 0 comments
Labels
D-easy Difficulty: easy P-low Priority: low T-design Type: discuss API design and/or research T-refactor Type: cleanup/refactor T-test Type: test improvements

Comments

@LukePearson1
Copy link
Contributor

The WitnessTable defined in plonk-core/src/lookup/witness_table.rs is only used during testing but not used in the public API anywhere. We should consider removing it and replacing the tests with the relevant alternatives using the other lookup primitives.
@LukePearson1 LukePearson1 added D-easy Difficulty: easy P-low Priority: low T-design Type: discuss API design and/or research T-refactor Type: cleanup/refactor T-test Type: test improvements labels Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
D-easy Difficulty: easy P-low Priority: low T-design Type: discuss API design and/or research T-refactor Type: cleanup/refactor T-test Type: test improvements
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@LukePearson1