-
-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Has anybody actulay got this to work ? #15
Comments
Does almost count? :p I think I have most of it worked out but I'm still stumbling on the InsightFace loader. However I think it might be because of the version of |
Got it technically working on Windows (not on Mac yet), but the resulting images look nothing like the input face. |
I got it to work on windows, but the VRAM consumption is very weird, with a huge peak right after the generation process, and the results are not that good, the pose is always the same as the input picture, and the face is not that resembling |
try this - https://github.com/huxiuhan/comfyui-instantid UPDATE but hitting a snag with controlnet asking for a config.json maybe needs one of these clone this and specify path in first node. ComfyUI/models/controlnet/sd-controlnet-mlsd |
@b4sh - what did you use for controlnet loader? |
|
To be honest, as InstantID is now implemented in diffusers, I hope we might get a proper implementation. On top of other issues, just like with PhotoMaker we have an issue with two competing implementations with the same name even. |
I had this error, just having the json file in the same directory as the controlnet model and renaming the json to config.json was enough to solve this for me. It requires you to download the json file with the controlnet model if you didn't realize. I got it working on my CPU, but it doesn't recognize cuda for some reason... In order to get it to work on cpu, I had to uninstall IPAdapter, rename the json to config.json, redownload all the antelopev2 files and replace them in the models/antelopev2 folder... idk if I will try to solve the cuda error or just wait for a proper implementation. |
Yeah the json file is easy just missing from the instructions. In the same place you downloaded the controlnet model, download the config json from that same place and name it "config.json" and put it in the same location. My issue is with insightface and the InsightFace Loader. I can't install insightface normally though |
are you on right python version? 3.11 ? show the logs when comfyui loads. my impression with instantid from workflows in this repo - I want to have more control of the style. I attempt to load this image as an artist - but couldn't create anything that resembled this image. need to explore more. |
3.11.6. I'm 90% certain it is coming from m y install of |
try this pip install 'https://github.com/Gourieff/Assets/raw/main/Insightface/insightface-0.7.3-cp311-cp311-win_amd64.whl' or attempt to get this module to install |
Installing from that wheel at least gets me a new error so that's progress :D
|
Ahh looking at files on disk I believe my downloads of the onnx models were corrupoted. I will redownload them. |
Thank you! That wheel was exactly what I needed. With that I got it all working! |
I will note for people who might be getting "safety check" errors. Someone correct me if I'm wrong but it seems to only work using SDXL based models? |
for now, yep. fyi there's an pytorch2 hotfix upstream that may speed up things (can't tell). |
Why is it so slow? I have to wait 15 minutes for it to finish 50 steps * Rtx 3080 |
It might be that onnx is using CPU. I am having that issue and can't figure out why. That said it is still nowhere near as slow as what you are saying. |
@jwvanderbeck how did you fix the |
Yeah I just redownloaded all the antelopev2 models
- John Vanderbeck
- http://www.johnvanderbeck.com
…On Fri, Jan 26, 2024 at 12:45 PM PublicPrompts ***@***.***> wrote:
@jwvanderbeck <https://github.com/jwvanderbeck> how did you fix the
[ONNXRuntimeError] : 7 : INVALID_PROTOBUF : Load model from F:\Generative
Art
Tools\ComfyUI\custom_nodes\ComfyUI-InstantID\models\antelopev2\1k3d68.onnx
failed:Protobuf parsing failed.
—
Reply to this email directly, view it on GitHub
<#15 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABHKZRRSX2VA2IFGXZYKA3YQPTSVAVCNFSM6AAAAABCHTGIF2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMJSGQ2DIMJTGE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
oh that's it. i redownloaded the onnx from here https://huggingface.co/DIAMONIK7777/antelopev2/tree/main |
I wonder why these files in the antelopev2 folder keep getting overwritten with the broken 1kb version. I had this node working last night, and when I tried again today, it was broken. I checked these files, and they were back to the 1kb versions. I had to redownload the correct files. That's frustrating. |
Because they are in the repo.
- John Vanderbeck
- http://www.johnvanderbeck.com
…On Fri, Jan 26, 2024 at 8:59 PM DarthBuckeye ***@***.***> wrote:
I wonder why these files in the antelopev2 folder keep getting overwritten
with the broken 1kb version. I had this node working last night, and when I
tried again today, it was broken. I checked these files, and they were back
to the 1kb versions. I had to redownload the correct files. That's
frustrating.
—
Reply to this email directly, view it on GitHub
<#15 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABHKZTSHJPXQG44OQCPQ5LYQRNQBAVCNFSM6AAAAABCHTGIF2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMJSHEYTCNJTGQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Makes sense. I guess the owner if this repo just doesn't care enough to make his work user friendly. I'm hoping for a better made version of InstantID soon. |
No need to be so harsh. A lot of times people do this for themself first
and then just share it with others that want to jump in. They have no
obligation. Would you have been happier if they just kept it to themself?
- John Vanderbeck
- http://www.johnvanderbeck.com
…On Fri, Jan 26, 2024 at 9:03 PM DarthBuckeye ***@***.***> wrote:
Because they are in the repo. - John Vanderbeck -
http://www.johnvanderbeck.com
Makes sense. I guess the owner if this repo just doesn't care enough to
make his work user friendly. I'm hoping for a better made version of
InstantID soon.
—
Reply to this email directly, view it on GitHub
<#15 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABHKZREGNBFRZSVZZLGRO3YQRN5LAVCNFSM6AAAAABCHTGIF2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMJSHEYTENZSGY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
@jwvanderbeck I probably would be, actually. 😂 I've spent three nights trying to get this to work and still haven't been able to get an image out of it. |
@camoody1 Same, It was working prefect and today after an update, it stopped working until replaced by newly redownloaded onnx. But still instantID is a must have, Results are amazing! |
So, I was finally able to get some images out of this workflow after a LOT of memory and node struggles. And while the faces truly are amazing in stylized images, I have to say, the photorealistic image quality is really quite poor. Even with the Style set to "none" and my prompt including "raw photo, 8k uhd, ultra-detailed", the output looks blurry and grainy. I can convert the image to a latent, upscale it and then run it through a KSampler to make it come out gorgeous, but that totally removes the face likeness that is the whole point of the process. I'm not sure what is happening with the code behind the scenes, but if you're looking to produce a high-quality, photorealistic image, IPAdapter is still the better option. |
@camoody1 - this might be the way to get faceswap to work better - instantX-research/InstantID#89 |
Yes. This would be very nice to have. Also, anything that could reduce the VRAM required would be huge. |
Well, sadly, I had this working last night, but as I come back to use it again tonight, VRAM memory issues, again. My 12GB 3060 must be right on the teetering edge of being usable. Unreal. |
I'm at a stage where I think this is just a malicious prank breaking everybody's confyUI's
The text was updated successfully, but these errors were encountered: