Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

False alarms about GraphGenie #3

Open
ljhhuxiaoba opened this issue Nov 10, 2023 · 3 comments
Open

False alarms about GraphGenie #3

ljhhuxiaoba opened this issue Nov 10, 2023 · 3 comments

Comments

@ljhhuxiaoba
Copy link

I ran GraphGenie for 1 hour on Redisgraph and found some problems in some test case pairs:
First:
base query:OPTIONAL MATCH (iqdwmbdq:Movie)-[]->() WHERE iqdwmbdq IS NOT NULL RETURN count(iqdwmbdq)
test query:OPTIONAL MATCH (iqdwmbdq:Movie)-[]->() WHERE iqdwmbdq IS NOT NULL RETURN count()
Second:
base query:OPTIONAL MATCH ()-[]->()-[]->()-[
..1]->()<-[]-()<-[]-() WHERE True RETURN count(1) ORDER BY NULL
test query:MATCH ()-[]->()-[]->()-[*..1]->()<-[]-()<-[]-() WHERE True WITH * WHERE True AND True AND True RETURN count(1) ORDER BY NULL

And I think these two are false alarms because "count(iqdwmbdq) " is not equivalent to "count(*)" and "OPTIONAL MATCH" is not equivalent to "MATCH".But it says that " our test oracle only identified bugs caused by semantic discrepancies,
ensuring that GraphGenie only reports true logic bugs." in initial paper, so I wonder if these are my misjudgment.

Looking forward to your reply.

@YuanchengJiang
Copy link
Owner

Hi @ljhhuxiaoba, technically the oracle of GraphGenie has no false alarm like differential testing (e.g., same bug exists in multiple db instances). However, the implementation could have false alarms, which means GraphGenie could have an inaccurate transformation rule that generates inequivalent queries (also one valid transformation might be incorrect in another graph db). I'd be happy to fix them.

@ljhhuxiaoba
Copy link
Author

Thank you for your response. I am using GraphGenie as baseline in my paper so please keep me informed if there is an updated version, thanks.

@YuanchengJiang
Copy link
Owner

@ljhhuxiaoba wondering why OPTIONAL MATCH (iqdwmbdq:Movie)-[]->() WHERE iqdwmbdq IS NOT NULL RETURN count(iqdwmbdq) is semantically different from OPTIONAL MATCH (iqdwmbdq:Movie)-[]->() WHERE iqdwmbdq IS NOT NULL RETURN count()? Could you illustrate more on it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants