Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evaluate twisted event loop #171

Open
dnephin opened this issue Jul 18, 2012 · 3 comments
Open

Evaluate twisted event loop #171

dnephin opened this issue Jul 18, 2012 · 3 comments

Comments

@dnephin
Copy link
Contributor

dnephin commented Jul 18, 2012

Is it possible we could replace the twisted event loop with monocle or another alternative?

It would most likely mean replacing the ssh client with paramiko or something related.

@dnephin
Copy link
Contributor Author

dnephin commented Jul 18, 2012

If we do continue to use twisted, the reactor imports should be cleaned up so that a reactor instance is passed around instead of using a global import.

@irskep
Copy link
Contributor

irskep commented Jul 18, 2012

I'm definitely in support of kicking Twisted out and using Paramiko for SSH. We don't have that many Twisted API calls throughout the code, just a few key places. And lots of test cases, which is the hard part I guess.

I'm not familiar with monocle.

@dnephin
Copy link
Contributor Author

dnephin commented Feb 9, 2013

As a first pass all references to twisted internals will be moved into a single eventloop module, and the rest of the code will make calls to that module. This should make it much easier to swap out twisted later on, if necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants