Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REFACTOR] Move the hardcoded strings in the project to strings.xml #159

Open
Yash-Garg opened this issue Nov 7, 2022 · 1 comment
Open

[REFACTOR] Move the hardcoded strings in the project to strings.xml #159

Yash-Garg opened this issue Nov 7, 2022 · 1 comment
Assignees
@nishithkhanna
Labels
C-feature New feature or request P-medium Priority: medium S-awaiting-development Status: New issues that have not been looked upon
Milestone
v1.0

Comments

@Yash-Garg
Copy link
Owner

Yash-Garg commented Nov 7, 2022 •
edited
Loading

Move hardcoded strings like below, throughout the project to strings.xml.

qBittorrent-Manager/app/src/main/kotlin/dev/yashgarg/qbit/ui/dialogs/AddTorrentDialog.kt

Lines 43 to 50 in 8fb7625

// TODO: Switch to string resources below
alertDialogBuilder.apply {
setTitle("Add Magnet Link")
setView(R.layout.edit_text)
setNeutralButton("Upload File", null)
setNegativeButton("Cancel") { dialog, _ -> dialog.dismiss() }
setPositiveButton("Add", null)
}

@Yash-Garg Yash-Garg added this to the v1.0 milestone Nov 7, 2022
@Yash-Garg Yash-Garg added C-feature New feature or request hacktoberfest labels Nov 7, 2022
@Yash-Garg Yash-Garg changed the title [REFACTOR] Move the hardcoded strings in the project to string.xml [REFACTOR] Move the hardcoded strings in the project to strings.xml Nov 8, 2022
@nishithkhanna
Copy link

@Yash-Garg I will be able to handle it

@Yash-Garg Yash-Garg added P-medium Priority: medium S-awaiting-development Status: New issues that have not been looked upon and removed hacktoberfest labels Dec 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nishithkhanna nishithkhanna

Labels
C-feature New feature or request P-medium Priority: medium S-awaiting-development Status: New issues that have not been looked upon
Projects
None yet
Milestone
v1.0
Development

No branches or pull requests
2 participants
@nishithkhanna @Yash-Garg