Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional deletion confirmation dialogue #11

Open
Garbaz opened this issue Sep 7, 2022 · 3 comments
Open

Optional deletion confirmation dialogue #11

Garbaz opened this issue Sep 7, 2022 · 3 comments

Comments

@Garbaz
Copy link

Garbaz commented Sep 7, 2022

Hi,

I am aware that the deletion confirmation dialogue was removed due to #4, but for me personally, it would be very useful if I could re-enable it. I'm not very dexterous with my phone sometimes and from time to time hit the Delete button by accident when I wanted to press Edit or just swipe over the notification. With no confirmation dialogue, this means that I just loose the entire note by accident.

If introducing a whole options menu for this would be too much effort, perhaps a "Always delete without asking" checkbox could be added to the confirmation dialogue for anyone who does not wish for it to come up.

@Yanndroid
Copy link
Owner

I was actually thinking the same thing not so long ago, because I noticed that deleting a screenshot also has a confirmation dialog. And another checkbox also came to mind, but adding more and more checkboxes isn't really the solution in my opinion. So I actually have some ideas.

  1. Add a settings icon to the dialog where you have all the preferences (to keep the main dialog clean)
  2. After deleting a note, show a toast/snackbar with an undo button
  3. (Add a settings activity. Not ideal for note specific settings)

The first one is kind of my favorite, since this will allow me to add more preferences in the future.
What do you think?

@Garbaz
Copy link
Author

Garbaz commented Sep 8, 2022

I think having a preference menu would be good, also in general for other customization.

But I also like the undo toast idea. Maybe that could be what happens if you disable the confirmation dialogue? So if someone just wants to delete a lot of notes at once (like in #4), they can do it, but they still get some safety against accidental deletes.

Also, maybe some ideas for other possible options that could be added to the preference menu:

  • What the default should be for note color/"Hide on lockscreen"/"Lock in notifications" for new notes
  • Whether to show the Edit/Delete buttons in the notification
  • What should happen when one taps on the note itself (Current popup/Do Edit directly/Do Delete directly)

@Wjxfi
Copy link

Wjxfi commented Sep 18, 2022

I think you're the only one with this problem. If you want to add it, then add the option to enable it. You don't need to put horrible dialog by default

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants