Re-design getObject method with filter #18
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YJack0000
changed the title
|
Please provide implementation with document for more discussion. |
YJack0000
force-pushed
the
main
branch
3 times, most recently
from
c853568 to
dc6f00e
Compare
|
Got it, the puml I provided was used for easy discussion so that we can have a full picture of the design. I will combine both implementation and diagram in the pull request in the future, But I think we can still have some discussion on the diagram first and implement it after we agree on the design, preventing working for nothing. |
|
Maybe change to other branch directly specify the feature |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.