Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement abrupt HY/CG interface #29

Closed
J-Hizzle opened this issue Jan 21, 2025 · 3 comments
Closed

implement abrupt HY/CG interface #29

J-Hizzle opened this issue Jan 21, 2025 · 3 comments

Comments

@J-Hizzle
Copy link
Contributor

J-Hizzle commented Jan 21, 2025

In the latest TR version of AdResS, there is an abrupt switching off of interactions at the HY/CG interface, which is called the Delta/TR interface in this context. This requires the implementation of a new type of weighting function that is simply 1 throughout HY and 0 in CG. Whilst this would technically be already achieved in the current version of MRMD by setting the HY region diameter to 0, measurement of physical observables would be done up to the Delta/TR interface, which would be stained by the interface artifacts and thus this needs to be circumvented.

I suggest refactoring Slab.hpp:96-109 as a dedicated function and adding another function that would make the interface abrupt.

@XzzX
Copy link
Owner

XzzX commented Jan 21, 2025

Why exactly is setting HY diameter to 0 a problem? I am open for some refactoring.

@J-Hizzle
Copy link
Contributor Author

One Example would be that the thermodynamic force is only applied within the HY region, if I understand ThermodynamicForce.cpp:147 correctly. In the case of a HY region with 0 diameter, this would break the thermodynamic force as it is at the moment. I could also imagine there being other cases like that within MRMD when setting the HY region to 0 diameter.

Short notice on the application region of the thermodynamic force: I will most probably need to rework this as well, since for the abrupt interface, the thermodynamic force needs to be applied also within the CG region.

@XzzX
Copy link
Owner

XzzX commented Jan 31, 2025

fixed by #31

@XzzX XzzX closed this as completed Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants