Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing tetrazole acidic nitrogen SMARTS pattern #2

Open
rubbs14 opened this issue Nov 19, 2021 · 1 comment
Open

Missing tetrazole acidic nitrogen SMARTS pattern #2

rubbs14 opened this issue Nov 19, 2021 · 1 comment

Comments

@rubbs14
Copy link

rubbs14 commented Nov 19, 2021

Hi, first of all, congrats on a great job!
I forked the repo and I was playing around with some test sets. While testing some N heterocycles, I noticed that the acidic nitrogen in tetrazole was ignored by the prediction function.
I added the SMARTS definition for the acidic nitrogen to the tsv file and uploaded it to my fork. The definition is:
[nH&!$(n@[cR2])]
This will only match the aromatic hydrogen-bearing nitrogen in tetrazoles.
When I added it, the model predicts a pKa of 7.1 for 1H- and 2H-tetrazole, which is not correct.
image
I think it would be interesting to retrain the model including also this definition.

@pykao
Copy link

pykao commented Dec 8, 2021

Hi @rubbs14, I think you should retrain the MolGpKa model again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants