step_hw_ipgen : 'set_top': Argument 'name' requires a value!

[kalahel]

Hello,

I'm trying to run the full finn pipeline on a fairly simple model but I get an error at step 13 : step_hw_ipgen.

Here is the steps :

def custom_step_add_post_proc(model: ModelWrapper, cfg: build.DataflowBuildConfig):
    model = model.transform(InsertTopK(k=1))
    return model
    
build_steps = [
    custom_step_add_post_proc,
    "step_qonnx_to_finn",
    "step_tidy_up",
    "step_streamline",
    "step_convert_to_hw",
    "step_create_dataflow_partition",
    "step_specialize_layers",
    "step_target_fps_parallelization",
    "step_apply_folding_config",
    "step_minimize_bit_width",
    "step_generate_estimate_reports",
    "step_hw_codegen",
    "step_hw_ipgen",
    "step_set_fifo_depths",
    "step_create_stitched_ip",
    "step_measure_rtlsim_performance",
    "step_out_of_context_synthesis",
    "step_synthesize_bitfile",
    "step_make_pynq_driver",
    "step_deployment_package",
]

cfg_build = build.DataflowBuildConfig(
    output_dir=output_dir,
    mvau_wwidth_max=80,
    synth_clk_period_ns=10.0,
    # specialize_layers_config_file = "specialize_layers_all_hls.json",
    # folding_config_file="cnv-w2a2_folding_config.json",
    board="Pynq-Z2",
    shell_flow_type=build_cfg.ShellFlowType.VIVADO_ZYNQ,
    steps=build_steps,
    default_swg_exception=True,
    generate_outputs=[
        build_cfg.DataflowOutputType.ESTIMATE_REPORTS,
        build_cfg.DataflowOutputType.STITCHED_IP,
        build_cfg.DataflowOutputType.RTLSIM_PERFORMANCE,
        build_cfg.DataflowOutputType.OOC_SYNTH,
        build_cfg.DataflowOutputType.BITFILE,
        build_cfg.DataflowOutputType.PYNQ_DRIVER,
        build_cfg.DataflowOutputType.DEPLOYMENT_PACKAGE,
    ],
)

When I run it I get this :

Build log is at /mnt/c/Dev/finn/notebooks/advanced/split_model_second_half/output_pre_proc/build_dataflow.log
Running step: custom_step_add_post_proc [1/20]
Running step: step_qonnx_to_finn [2/20]
Running step: step_tidy_up [3/20]
Running step: step_streamline [4/20]
Running step: step_convert_to_hw [5/20]
Running step: step_create_dataflow_partition [6/20]
Running step: step_specialize_layers [7/20]
Running step: step_target_fps_parallelization [8/20]
Running step: step_apply_folding_config [9/20]
Running step: step_minimize_bit_width [10/20]
Running step: step_generate_estimate_reports [11/20]
Running step: step_hw_codegen [12/20]
Running step: step_hw_ipgen [13/20]
multiprocessing.pool.RemoteTraceback:
"""
Traceback (most recent call last):
  File "/usr/lib/python3.10/multiprocessing/pool.py", line 125, in worker
    result = (True, func(*args, **kwds))
  File "/usr/lib/python3.10/multiprocessing/pool.py", line 48, in mapstar
    return list(map(*args))
  File "/mnt/c/Dev/finn/src/finn/transformation/fpgadataflow/hlssynth_ip.py", line 72, in applyNodeLocal
    inst.ipgen_singlenode_code()
  File "/mnt/c/Dev/finn/src/finn/custom_op/fpgadataflow/hlsbackend.py", line 186, in ipgen_singlenode_code
    assert os.path.isdir(ip_path), "IPGen failed: %s not found. Check log under %s" % (
AssertionError: IPGen failed: /tmp/finn_dev_mathhann/code_gen_ipgen__amqgjj1x/project_/sol1/impl/ip not found. Check log under /tmp/finn_dev_mathhann/code_gen_ipgen__amqgjj1x
"""

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/mnt/c/Dev/finn/src/finn/builder/build_dataflow.py", line 158, in build_dataflow_cfg
    model = transform_step(model, cfg)
  File "/mnt/c/Dev/finn/src/finn/builder/build_dataflow_steps.py", line 523, in step_hw_ipgen
    model = model.transform(HLSSynthIP())
  File "/mnt/c/Dev/finn/deps/qonnx/src/qonnx/core/modelwrapper.py", line 140, in transform
    (transformed_model, model_was_changed) = transformation.apply(transformed_model)
  File "/mnt/c/Dev/finn/deps/qonnx/src/qonnx/transformation/base.py", line 111, in apply
    new_nodes_and_bool = p.map(self.applyNodeLocal, old_nodes, chunksize=1)
  File "/usr/lib/python3.10/multiprocessing/pool.py", line 367, in map
    return self._map_async(func, iterable, mapstar, chunksize).get()
  File "/usr/lib/python3.10/multiprocessing/pool.py", line 774, in get
    raise self._value
AssertionError: IPGen failed: /tmp/finn_dev_mathhann/code_gen_ipgen__amqgjj1x/project_/sol1/impl/ip not found. Check log under /tmp/finn_dev_mathhann/code_gen_ipgen__amqgjj1x
> /usr/lib/python3.10/multiprocessing/pool.py(774)get()
-> raise self._value

When I check the log here what I get :

ERROR: [HLS 200-101] 'set_top': Argument 'name' requires a value!
SYNTAX 
  set_top <name>
    name :  <string>  (required)

And going from there if I check the hls_synth.tcl there is set config_toplevelfxn "", but I struggle to get why and how can I fix this ?

Here is the full log and image of the model :
vitis_hls.log

[kalahel]

Hello again,

I found the problem, it is caused by step_apply_folding_config, if called without a folding file, it will not call model = model.transform(GiveUniqueNodeNames()) thus giving an onnx model with nodes without names.