New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Possible wrong formulation on the Neumann boundary condition. #751

Open

Xiangyu-Hu opened this issue Feb 16, 2025 · 0 comments

Assignees

Labels

bug

Owner

Xiangyu-Hu commented Feb 16, 2025

SPHinXsys/src/shared/particle_dynamics/diffusion_reaction_dynamics/diffusion_dynamics.hpp

Lines 259 to 262 in 73847e0

    
           const Vecd &grad_ijV_j = this->contact_kernel_gradients_[k](index_i, index_j, dW_ijV_j, e_ij); 
        
           Vecd n_ij = n_[index_i] - n_k[index_j]; 
        
           Real area_ij_Neumann = grad_ijV_j.dot(n_ij); 
        
           getDiffusionChangeRateNeumann(index_i, index_j, area_ij_Neumann, diffusive_flux_k);

Here, difference of normal direction seems making no sense.

@ChenxiZhaoTUM
@Bo-Zhang1995
Could you have a look on it?

Xiangyu-Hu added the bug label

Xiangyu-Hu assigned Bo-Zhang1995 and ChenxiZhaoTUM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment