-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wall velocity for Eulerian SPH is not correct. #476
Comments
@ZhentongWang could you have a look at it? Thanks. |
Yes, the velocity in wall as vel_in_wall = 2 * vel_ave - v_i. I was just considering the static wall boundary condition for Eulerian cases in current, so the vel_ave is always zero. When I simulate the lid-driven cavity in Eulerian SPH method, I also use the equation vel_in_wall = 2 * vel_ave - v_i but have not changed that equation in the current master. Therefore, the general equation for velocity in wall boundary is vel_j = 2 * vel_wall - v_i. |
@ZhentongWang So, should we change the code on this? |
yes, I will change the code and use the more general equation for wall velocity soon. |
@ZhentongWang Is this done already? |
I have created a pull request to have it fixed. |
@ZhentongWang Could link this issue to the branch for fixing? So that, this issue will close automatically after the pull request is done. |
SPHinXsys/src/shared/particle_dynamics/fluid_dynamics/eulerian_fluid_dynamics/eulerian_fluid_integration.hpp
Line 141 in c2c30ec
The wall speed is not correct for the Eulerian SPH when it involves the wall.
For example, if the wall has a speed, like lip driven cavity, the wall speed should not be the negative speed of the particle i.
It should be like the LG sph, vel_j = 2 * vel_wall - v_i.
The text was updated successfully, but these errors were encountered: