Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weekly plan 01-30-2025 #16

Closed
5 tasks done
XiangpengHao opened this issue Jan 30, 2025 · 7 comments · Fixed by #22
Closed
5 tasks done

Weekly plan 01-30-2025 #16

XiangpengHao opened this issue Jan 30, 2025 · 7 comments · Fixed by #22

Comments

@XiangpengHao
Copy link
Owner

XiangpengHao commented Jan 30, 2025

The highest priority for me is to get a complete ClickBench with reasonable performance.

  • Run entire ClickBench (@XiangpengHao )
  • Collect reasonable metrics
  • Ensure the results we get are correct (@WetABQ working on this)
  • Optimize some of the decoding stuff, as they show up in the flamegraph
  • Sign off this task and verify the system behave as expected.

Before Monday: Xiangpeng run and tune entire ClickBench.

Before Wednesday meeting, try to make the Figure 1 in #15

@XiangpengHao XiangpengHao pinned this issue Jan 30, 2025
@XiangpengHao
Copy link
Owner Author

This is how I check ClickBench results before: https://github.com/XiangpengHao/datafusion/blob/research/benchmarks/src/clickbench.rs#L245

It can be a good starting point, we probably need something more comprehensive than this. @WetABQ

@XiangpengHao
Copy link
Owner Author

XiangpengHao commented Jan 31, 2025

The goal of this series of todo is to get back the performance to what we present in the talks

My next todo:

  • automatically collect a flamegraph after one query
  • Cache the metadata in parquet factory
  • automatically save stats after a query
  • Write benchmark results to file
  • Consume batches in cached_array reader will decode multiple times, we should merge them into once.
  • merge smaller batches into larger batches before sending over network
  • We should never use schema mapper in client
  • Disable arrow ipc bounds check
  • Introduce a metric system, want to know: how many bytes sent over network, the record batch size distribution, selectivity etc.

Automatically collect:

  • Overall latency
  • network traffic
  • time spent on cache server
  • time spent on compute server
  • cache memory consumption

@XiangpengHao
Copy link
Owner Author

Filed spiraldb/fsst#69, which they fixed in a minute. Will bump our dependencies once it releases

@XiangpengHao
Copy link
Owner Author

We are currently blocked by this: apache/arrow-rs#7058

Need to fix it as soon as possible

@XiangpengHao
Copy link
Owner Author

We are currently blocked by this: apache/arrow-rs#7058

Need to fix it as soon as possible

Tried to fix it, but failed, the flatbuffer is too difficult to debug... But I find a way to workaround it, so we good now.

@WetABQ WetABQ linked a pull request Feb 2, 2025 that will close this issue
XiangpengHao added a commit that referenced this issue Feb 3, 2025
Related #16

---------

Co-authored-by: Xiangpeng Hao <[email protected]>
@WetABQ WetABQ reopened this Feb 3, 2025
@XiangpengHao
Copy link
Owner Author

Done

@XiangpengHao XiangpengHao unpinned this issue Feb 11, 2025
@XiangpengHao
Copy link
Owner Author

next: #42

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants