Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question about typical decoding baseline #3

Open
dlvp opened this issue Nov 14, 2022 · 1 comment
Open

Question about typical decoding baseline #3

dlvp opened this issue Nov 14, 2022 · 1 comment

Comments

@dlvp
Copy link

dlvp commented Nov 14, 2022

Hello @XiangLi1999 and @ari-holtzman,
I'm trying to follow the implementation of the typical decoding baselines in the code base.
Here a typical argument is passed, but the generate method does not accept any such argument but only an optional argument typical_p. At the same time I am unable to find any call to model_kwargs['"typical"] anywhere so it seems no warping of the logits to do typical sampling is ever performed.
Am I missing something trivial?

@XiangLi1999
Copy link
Owner

Hi,

Thanks for pointing this out! I think this is my bad, the right thing is to change "typical=0.95" to "typical_p=0.95". I will fix this code release and double check my experiments. This might just be something I dropped when migrating my code base from dev to release.

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants