This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Create an action for test deployments for docs builds #595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah I also do not have secrets access :( so lets not merge it right now |
|
I looked at the fork though and i do really like that change, so I think it is a needed one |
This should make the header links work in both production and test deployments.
Actually, this doesn't work as expected, since it causes queued deploys to be skipped.
Why is YAML such a weird format? The strings and arrays are so strange.
|
Alright, I think this is pretty much completed. We just need to set up Cloudflare and the secrets before merging. |
|
@MatthewL246 Maybe email roche today. I have the password for our cloud flare account if you need it |
|
@michaell4438 Done. Did you reserve the Pages project domain? |
|
Alright, the Cloudflare project is ready: xbhs-robotics-docs.pages.dev. I'll create the API token when necessary. |
|
Your docs changes were built successfully! View a preview of them at https://f382469e.xbhs-robotics-docs.pages.dev |
|
@michaell4438 can i haz approval |
michaell4438
approved these changes
Nov 27, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
I created a job for the GitHub Pages action that uploads a test deployment to Cloudflare Pages. I tested this on my fork using my own Cloudflare account, see an example PR here: https://github.com/MatthewL246/FtcRobotController/pull/7.
Controls and Usage:
When you are making a documentation update, make sure to name your branch starting with
docs/. After the build completes, you will receive a comment from the GitHub Actions bot on your PR with a link to a preview of the deployment.Required steps before merging:
xbhs-robotics-docs.pages.dev.CLOUDFLARE_ACCOUNT_IDwith the account ID.CLOUDFLARE_API_TOKENwith an API token that has edit access toAccount.Cloudflare Pages.Reviewers:
@XaverianTeamRobotics/senior-programmers
Closes #593.