Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TransactionStream type is wrong when using API version 2 #2767

Open
justmoon opened this issue Sep 1, 2024 · 0 comments · May be fixed by #2779
Open

TransactionStream type is wrong when using API version 2 #2767

justmoon opened this issue Sep 1, 2024 · 0 comments · May be fixed by #2779

Comments

@justmoon
Copy link
Contributor

justmoon commented Sep 1, 2024

In src/models/methods/subscribe.ts, line 289 the TransactionStream type declares a field called transaction which contains the main transaction data.

However, in reality, when using API version 2, this field appears to be called tx_json now.

It appears that similar changes were in fact taken into account in other places, such as here in accountTx.ts but overlooked in this instance.
justmoon added a commit to justmoon/dassie that referenced this issue Sep 1, 2024
@justmoon
fix(node): downgrade xrpl.js to 3.1.0
d46aac9 
There is a regression in 4.0.0, see XRPLF/xrpl.js#2767
@mvadari mvadari linked a pull request Sep 17, 2024 that will close this issue
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: resolve TransactionStream and Ledger model issues XRPLF/xrpl.js
1 participant
@justmoon