You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hey @dachengx, I like the idea and would make the code cleaner! I was wondering if we could potentially get some problems with e.g the S2PhotonPropagation plugin that is a child plugin of S2PhotonPropagationBase which in turn inherits from strax.DownChunkingPlugin.
We would need to define maybe fusePlugin and fuseDownChunkingPlugin. Then let all fuse plugins inherit from there and not from strax plugins. The plugins setting the random seed for nestpy & scipy would need a little different setup function.
The code similar to
has appeared multiple times like here:
fuse/fuse/plugins/micro_physics/yields.py
Line 62 in 7946ccb
It is better to put them into a mother class and plugins can inherit this function from the mother class.
The text was updated successfully, but these errors were encountered: