New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prefixes in option names are redundant? #7

Open

mgrebenets opened this issue May 20, 2019 · 0 comments

mgrebenets commented May 20, 2019

I think prefixing each option name with altool_ is redundant.
It's already clear that these options are for altool action, so instead of

    altool(
        altool_username: ENV["FASTLANE_USER"],
        altool_password: ENV["FASTLANE_PASSWORD"],
        altool_app_type: "ios",
        altool_ipa_path: "./build/Your-ipa.ipa",
        altool_output_format: "xml",
    )

It should rather be:

    altool(
        username: ENV["FASTLANE_USER"],
        password: ENV["FASTLANE_PASSWORD"],
        app_type: "ios",
        ipa_path: "./build/Your-ipa.ipa",
        output_format: "xml",
    )

This will also make this plugin aligned with other Fastlane actions and plugins

The text was updated successfully, but these errors were encountered:

mgrebenets mentioned this issue

Drop altool_ prefix for all action options #10

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment