Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AML may crash if there are more than 50 missing dependencies #400

Open
RevZero opened this issue Nov 13, 2024 · 0 comments
Open

AML may crash if there are more than 50 missing dependencies #400

RevZero opened this issue Nov 13, 2024 · 0 comments
Assignees
Labels
Status: Implemented Indicates that the issue has been handled but may not have been merged. Type: Bug
Milestone

Comments

@RevZero
Copy link
Member

RevZero commented Nov 13, 2024

Steam batch requests are limited to 50 entities. ModList.LoadNotInstalledDependencies() does not consider this and causes an unhandled exception, if there are more than 50 missing dependencies.

AML version: 1.6.0-alpha

Sentry GUID: deb34fd0-5a69-43aa-af0c-72675905710d
Message: Max allowed number of identifiers is 50.

Stack: 
   at XCOM2Launcher.Steam.Workshop.GetDetailsAsync (System.Collections.Generic.List`1[T] identifiers, System.Boolean getFullDescription) [0x00046] in <945f4166d96c4a07a68fb71ffce5a119>:0 
  at XCOM2Launcher.Mod.ModList.LoadNotInstalledDependencies (System.Collections.Generic.List`1[T] requiredModIds) [0x0010e] in <945f4166d96c4a07a68fb71ffce5a119>:0 
  at XCOM2Launcher.Mod.ModList+<>c__DisplayClass32_0.<GetRequiredMods>b__2 () [0x0006d] in <945f4166d96c4a07a68fb71ffce5a119>:0 
  at XCOM2Launcher.Mod.ModList.GetRequiredMods (XCOM2Launcher.Mod.ModEntry mod, System.Boolean substituteDuplicates, System.Boolean skipIgnoredDependencies) [0x0016a] in <945f4166d96c4a07a68fb71ffce5a119>:0 
  at XCOM2Launcher.Mod.ModList.GetDependentMods (XCOM2Launcher.Mod.ModEntry mod, System.Boolean compareModId) [0x0002b] in <945f4166d96c4a07a68fb71ffce5a119>:0 
  at XCOM2Launcher.Forms.MainForm.DeleteMods (System.Collections.Generic.List`1[T] mods, System.Boolean keepEntries) [0x00034] in <945f4166d96c4a07a68fb71ffce5a119>:0 
  at XCOM2Launcher.Forms.MainForm.ConfirmDeleteMods (System.Collections.Generic.List`1[T] mods) [0x0005f] in <945f4166d96c4a07a68fb71ffce5a119>:0 
  at XCOM2Launcher.Forms.MainForm+<>c__DisplayClass102_0.<CreateModListContextMenu>b__14 (System.Object <p0>, System.EventArgs <p1>) [0x00000] in <945f4166d96c4a07a68fb71ffce5a119>:0 
@RevZero RevZero added Type: Bug Status: Accepted Confirmed bug or useful feature that should be worked on. labels Nov 13, 2024
@RevZero RevZero self-assigned this Nov 13, 2024
@RevZero RevZero added this to the v1.6 milestone Nov 14, 2024
@RevZero RevZero added Status: Implemented Indicates that the issue has been handled but may not have been merged. and removed Status: Accepted Confirmed bug or useful feature that should be worked on. labels Nov 14, 2024
RevZero added a commit that referenced this issue Nov 14, 2024
…r of missing (not installed) dependencies at once. Resolves #400.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Implemented Indicates that the issue has been handled but may not have been merged. Type: Bug
Projects
None yet
Development

No branches or pull requests

1 participant