Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some comments about pandora code #91

Open
LilySnow opened this issue Jul 30, 2021 · 1 comment
Open

some comments about pandora code #91

LilySnow opened this issue Jul 30, 2021 · 1 comment
Labels
Code quality enhancement New feature or request

Comments

@LilySnow
Copy link
Collaborator

  1. Please replace system() with one of subprocess functions, e.g. subprocess.check_call(), subprocess.check_output().
  2. Do not change directories in your code. (only use it for quick and dirty code).
@DarioMarzella DarioMarzella added enhancement New feature or request Code quality labels Sep 1, 2021
@DarioMarzella
Copy link
Collaborator

Additional comments on code quality and logic following:
3. PANDORA.Pandora object takes now the "output_dir" argument. This is not very logical. It should be moved to PANDORA.model.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code quality enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants