Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can't show the application icons using swicheroo 1.0.5 with wox 1.3 #5

Open
lunxian opened this issue May 15, 2016 · 24 comments
Open
Assignees
Labels

Comments

@lunxian
Copy link

lunxian commented May 15, 2016

all the icons are wox, not the application's.
picture is here:
https://cloud.githubusercontent.com/assets/550273/15266727/21b0830e-19e1-11e6-8029-a4a2f5413db7.png

@bao-qian
Copy link
Member

hi @lances101
I noticed that wox.switcheroo use custom memory cache to get application icon.
Then this cause the image path too long.
this is no longer needed, all icons are automatically cached internally.
just pass the executable path (e.g. C:\Program Files\7-Zip\7zg.exe), then wox will automatically pick the correct icon.

@lances101
Copy link
Member

Yea... I had to use custom memory caching since we were on .NET 3.5 and the caching that Switcheroo uses was introduced in 4.0.

I will update this later this week.

@lunxian
Copy link
Author

lunxian commented May 20, 2016

if release the new version, I will test it at first.

@lunxian
Copy link
Author

lunxian commented May 21, 2016

where to get switheroo 1.0.6?

@bao-qian
Copy link
Member

Wox.Plugin.Switcheroo.zip

I just finished it, don't hurry...

download it and rename it to Wox.Plugin.Switcheroo.wox
double click it, then choose use wox to open it

@bao-qian
Copy link
Member

bao-qian commented May 21, 2016

@lunxian please test it, and report bugs here.
@lances101
please update the plugin on getwox.com/plugin, since I don't have permission...
and alt+tab is fixed now, remember remove the buggy explanation

@lunxian
Copy link
Author

lunxian commented May 21, 2016

2016-05-21.log.txt

tested. I think the crash bug is fixed, but buggy there.
bug 1: application icons are wox's too.
bug2: alt+tab will crash the wox, with no error box, but process is disappeared.

@lunxian
Copy link
Author

lunxian commented May 21, 2016

image
bug 1: picture here.

@lances101
Copy link
Member

Sorry for the delayed replies, I'm on a trip right now. I will take care of this in 10 hours or so.

@bao-qian bao-qian reopened this May 21, 2016
@bao-qian
Copy link
Member

bao-qian commented May 21, 2016

@lunxian

  1. try delete imagecache
  2. and make sure you are using the new version of switcheroo....
  3. try new version of wox: https://ci.appveyor.com/project/happlebao/wox/build/1.3.64/artifacts

it's definitely working on my machine
image

@lances101
Copy link
Member

@happlebao updated the label. Tested on a couple of machines, works, but as you indicated requires deleting imagecache. Uploaded the plugin to WPM.

@lunxian please confirm that it works.

@bao-qian
Copy link
Member

@lances101 you could add a notice (delete imagecache.dat) in changelog

@lances101
Copy link
Member

@happlebao done.

@lunxian
Copy link
Author

lunxian commented May 22, 2016

@happlebao testing done! upgrade wox 1.3.64, wpm uninstall switcheroo 1.0.5 , delete image cache, then wpm install swicheroo 1.0.6. that works. icons is ok , and no crash.

but alt-tab is not well done. the wox is on top window, but lost input focus.

@lunxian
Copy link
Author

lunxian commented May 22, 2016

the input method cursor is on the wox inputbox, but can't input on the wox inputbox.

@bao-qian
Copy link
Member

@lunxian
I will lost focus occasionally.
It can be fixed by activate wox and then deactivate wox using alt+space,
then alt+tab is working again.

  1. is alt+tab not working occasionally or always in your machine?
  2. any errors in logs? try create a clean log:
    close wox -> delete old log -> open wox -> deactivate wox -> alt+tab

@lunxian
Copy link
Author

lunxian commented May 22, 2016

2016-05-22.log.txt

here is the log.

@lunxian
Copy link
Author

lunxian commented May 22, 2016

@happlebao the behavior of alt-tab is so confused ; can we change im for convenient communication?

@lances101
Copy link
Member

@lunxian @happlebao I will try to figure out what causes Wox not to gain focus. It must be related to the way that the hotkey is being hooked.

@lunxian what do you mean about alt-tab being confusing?

@lunxian
Copy link
Author

lunxian commented May 22, 2016

confusing:

  1. when pressed alt-tab, will show the windows alt-tab task list, and then will show the wox's inputbox. and if i press alt-tab to move wox, it work. but if i move to another task , it switche to the task, and show the wox inputbox on top. it's right?
  2. now, the alt-tab does not work in my machine. pressed alt-tab , but no wox's inputbox showed, and windows alt-tab can't move task list.

@lances101
Copy link
Member

@lunxian I think most of your confusion happens because at the current state Alt+Tab is buggy. It uses a hooking system because it needs to cancel Window's default alt-tab functionality.

The main idea is that you would use alt+tab as a hotkey to use Switcheroo and from there you would be able to type the name of the application (just as you can do now if you type win into Wox). This would allow fast navigation between windows.

@lunxian
Copy link
Author

lunxian commented May 22, 2016

yes, you are right.

@lunxian
Copy link
Author

lunxian commented May 22, 2016

I am so sad that "buggy" should be added in the release note.

@bao-qian
Copy link
Member

bao-qian commented Jun 1, 2016

@lunxian 如果你用 1.3.67
你按了 alt+tab 后,wox 的输入框不能输入是吗?(焦点不在输入框上)
如果是,那么 win+r (shell 插件)能正确聚焦吗?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants