Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: Export to TSM Group #756

Open
argent-codes opened this issue Sep 8, 2024 · 2 comments
Open

Suggestion: Export to TSM Group #756

argent-codes opened this issue Sep 8, 2024 · 2 comments

Comments

@argent-codes
Copy link

One (little?) feature I would love is the ability to export my entire Rarity collection (or at least the drops that can be sold on the AH) as a TradeSkillMaster group, so I can import it there and more easily search for deals on some of these items. I can see this information in the Market Price column of Rarity's window, but it's not everything (for example, the Droplet of Y'Shaarj doesn't have a market price value but it's definitely available in the AH - and its Rarity config appears to have the correct item, spell, and creature IDs). Plus, market price is not super valuable to me out in the field, I need the data when I am at the auction house.

@rdw-software
Copy link
Member

I don't mind at all as long as it's optional. Meaning the addon still works all the same if TSM isn't present, just like it does now.

A few considerations, keeping in mind that I haven't used TSM in many years:

  • Where would the export button be located? It should be discoverable, but not get in the way or cramp the UI
  • How should Rarity deal with cases where items already exist in some other TSM groups? Just ignore them? Warn the user?
  • What happens if the item that Rarity tracks isn't one that TSM can use (pet cages, enchanted/custom items)?
  • And what about items that aren't really the collectible itself, but rather a "quest starter" or similar proxy?
  • If the button is pressed multiple times, possibly with changes to the Rarity DB in between, how does it update the group?

Finally, are you willing to investigate and implement such a feature? Or are you asking me/someone else to do it? :P

@rdw-software
Copy link
Member

for example, the Droplet of Y'Shaarj doesn't have a market price value but it's definitely available in the AH - and its Rarity config appears to have the correct item, spell, and creature IDs)

If you can narrow this down or Rarity used the wrong TSM APIs/price sources, feel free to open a separate issue :)

Plus, market price is not super valuable to me out in the field, I need the data when I am at the auction house.

I didn't develop the original TSM integration, but maybe the data could be hidden by default, or toggled manually?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Possibly some day (Undecided)
Development

No branches or pull requests

2 participants