Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an ElementVisitingSuggestorMixin for more advanced codemods #7

Open
evanweible-wf opened this issue Jan 15, 2019 · 1 comment · Fixed by #38
Open

Add an ElementVisitingSuggestorMixin for more advanced codemods #7

evanweible-wf opened this issue Jan 15, 2019 · 1 comment · Fixed by #38
Labels
help wanted Extra attention is needed

Comments

@evanweible-wf
Copy link
Contributor

The AstVisitingSuggestorMixin leverages the AstVisitor interface to help create suggestors, but it only makes the parsed AST available. Some more advanced or complex codemods may require additional information that is only available by resolving the elements via the analyzer. This would require setting up an AnalysisDriver or something similar from the analyzer package to resolve the elements.

Being able to leverage the ElementVisitor pattern would allow consumers to write suggestors that have more information with which to make decisions by being able to obtain things like the source of a type or an element's inheritance tree.

@evanweible-wf evanweible-wf added the help wanted Extra attention is needed label Jan 15, 2019
@TimWhiting
Copy link
Contributor

I needed something similar so I submitted a PR would #38 work?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
2 participants