Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't revalidate with Firefox - iframe modal closes upon click #180

Closed
dd32 opened this issue May 24, 2023 · 0 comments · Fixed by #185
Closed

Can't revalidate with Firefox - iframe modal closes upon click #180

dd32 opened this issue May 24, 2023 · 0 comments · Fixed by #185
Assignees
@adamwoodnz
Labels
bug Something isn't working priority: high ui Related to user interface
Milestone
MVP

Comments

@dd32
Copy link
Member

dd32 commented May 24, 2023

When the revalidation modal is triggered, it's not possible to click within the iframe part of it in Firefox.

This appears to be an upstream bug with the useFocusableIframe hook:
WordPress/gutenberg#40912 (comment)

Screen.Recording.2023-05-24.at.4.47.14.pm.mov
@dd32 dd32 added bug Something isn't working ui Related to user interface labels May 24, 2023
@iandunn iandunn added this to the Iteration 1 milestone May 24, 2023
@adamwoodnz adamwoodnz self-assigned this May 25, 2023
@adamwoodnz adamwoodnz moved this to In Progress in @adamwoodnz's WIP May 25, 2023
@adamwoodnz adamwoodnz mentioned this issue May 25, 2023
Merged
@dd32 dd32 modified the milestones: Iteration 1, MVP May 25, 2023
@dd32 dd32 closed this as completed in #185 May 25, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in @adamwoodnz's WIP May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adamwoodnz adamwoodnz

Labels
bug Something isn't working priority: high ui Related to user interface
Projects
@adamwoodnz's WIP
Status: Done
Milestone
MVP
Development

Successfully merging a pull request may close this issue.

Add workaround for reauth modal immediately closing in Firefox WordPress/wporg-two-factor
3 participants
@iandunn @dd32 @adamwoodnz