Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Design: People of WordPress _might_ be nicer to ensure we show headshots #254

Open
jeffpaul opened this issue Jan 28, 2022 · 4 comments
Open

Design: People of WordPress _might_ be nicer to ensure we show headshots #254

jeffpaul opened this issue Jan 28, 2022 · 4 comments
Labels
[Component] Content Issue in the site content, posts, pages, etc
Milestone
Post-Launch Itera...

Comments

@jeffpaul
Copy link
Member

I'm not sure what the current logic is for the People of WordPress section but it might be nicer to show all headshots and if possible their name as an overlay on the image / caption below the image? Right now the image for Devin Maeztri is kinda suboptimal as it crops out their actual photo.

Screen Shot 2022-01-28 at 12 02 53 PM
@coreymckrill
Copy link
Contributor

Looks like a classic thumbnail cropping-to-the-center issue. We might be able to get a better thumbnail for Devin's in particular. The tricky part with adding just their name as an overlay is that we'd probably need to save that as a separate postmeta value. Alternatively, we could overlay the post title, which includes their name, but then it might cover up a significant portion of the image...

@coreymckrill
Copy link
Contributor

@beafialho thoughts on this?

@coreymckrill coreymckrill added the [Type] Question Needs input from others before actionable label Jan 28, 2022
@iandunn
Copy link
Member

iandunn commented Jan 29, 2022

There's some earlier discussion in #111

@beafialho
Copy link
Collaborator

I agree with @jeffpaul about showing people's faces, that was the intent of this section. Maybe that's something we can edit directly in the post content by adding headshots or using the post's featured image?

As for showing the names, thanks for pointing that out, I missed opening up an issue for that. They should show up on hover, similarly to what happens in the Community section.

@beafialho beafialho mentioned this issue Jan 31, 2022
Closed
@beafialho beafialho added this to the Post-Launch Iteration 1 milestone Jan 31, 2022
@ryelle ryelle added [Component] Content Issue in the site content, posts, pages, etc and removed [Type] Question Needs input from others before actionable labels Feb 15, 2022
coreymckrill added a commit that referenced this issue Feb 17, 2022
@coreymckrill
Show post titles on hover, see #254
b18c0cc
@coreymckrill coreymckrill mentioned this issue Feb 17, 2022
Merged
coreymckrill added a commit that referenced this issue Feb 17, 2022
@coreymckrill @ryelle
Homepage People of WordPress: Match hover/focus effects used on the C…
04d8568 
…ommunity archive page (#327)

Syncs the color and transition effects of the post grid items on the Community archive page over to the grid items in the People of WordPress section of the homepage. It also ensures the post titles on grid items that have featured images are revealed on hover/focus, also like the Community archive page.

Fixes #267
Refs #254

Co-authored-by: Kelly Dwan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Component] Content Issue in the site content, posts, pages, etc
Projects
None yet
Milestone
Post-Launch Iteration 2
Development

No branches or pull requests
5 participants
@iandunn @ryelle @coreymckrill @jeffpaul @beafialho