Update background hover color for charcoal-1 nav menus

[ndiego]

When the background of a nav menu is set to --wp--preset--color--charcoal-1: #1e1e1e, such as in the case of Showcase v2, the submenu hover color is set to --wp--preset--color--nero: #1c2024 (reference). While this works well with the default background color of --wp--preset--color--charcoal-2: #1e1e1e, the hover color does not stand out very well when using charcoal-1.

Showcase (charcoal-1 + nero)	Other Pages (charcoal-2 + nero)

One possible solution is to set the hover color to charcoal-2.

(charcoal-1 + charcoal-2)

If approved, we would need to add the following to this file.

.has-charcoal-1-background-color {
	--wp-global-header--background-color--hover: var(--wp--preset--color--charcoal-2);
}

[ryelle]

For a little more context, this is the PR that introduced the ability to use a custom color for the block backgrounds. Previously, only white, blueberry-1, and charcoal-2 were supported. It just happens that the defaults work okay with charcoal-1, but any new color really should get some custom CSS to support it.

The CSS in the description should be correct, if that's the route to take. 👍🏻

[ndiego]

@jasmussen @marko-srb any thoughts on this? It would be nice to get updated along with Showcase if this is the direction we want to take. Thanks!

[jasmussen]

Just to be sure, you're suggesting we use charcoal 2 (bg) + charcoal 1 (menu) for other pages, and charcoal 1 (bg) and charcoal 2 (menu) for showcase? If yes, I agree.

[ndiego]

Just to be sure, you're suggesting we use charcoal 2 (bg) + charcoal 1 (menu) for other pages, and charcoal 1 (bg) and charcoal 2 (menu) for showcase? If yes, I agree.

Yup exactly. Cool, I'll get a PR together.