Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable color settings on the Footer block #341

Closed
ryelle opened this issue Feb 15, 2023 · 1 comment · Fixed by #350
Closed

Enable color settings on the Footer block #341

ryelle opened this issue Feb 15, 2023 · 1 comment · Fixed by #350
Assignees
@ryelle
Labels
[Block] Header & Footer

Comments

@ryelle
Copy link
Contributor

ryelle commented Feb 15, 2023

See WordPress/wporg-developer#213 (comment)

Hm... with the "expressive" sites, they'll probably introduce other footer variations with other colors. Do you think we should just keep adding variations, or maybe switch to enabling colors on the footer block, and set the background/text/link colors on the block instead?

Yeah, that makes sense. Let's make the block configurable.
@ryelle ryelle mentioned this issue Feb 15, 2023
Closed
@ryelle ryelle self-assigned this Feb 15, 2023
@ryelle
Copy link
Contributor Author

ryelle commented Feb 16, 2023

Ran into an issue with the existing attribute being named style, which conflicts with the way block supports adds custom backgrounds & borders. I'll try a deprecation function to see if that helps.

@ryelle ryelle mentioned this issue Mar 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ryelle ryelle

Labels
[Block] Header & Footer
Projects
None yet
Milestone
No milestone
1 participant
@ryelle