Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

Feature: Add update logs to update-core.php page #81

Open
abuyoyo opened this issue Apr 17, 2020 · 4 comments
Open

Feature: Add update logs to update-core.php page #81

abuyoyo opened this issue Apr 17, 2020 · 4 comments
Labels
enhancement New feature or request

Comments

@abuyoyo
Copy link

abuyoyo commented Apr 17, 2020

Easy Updates Manager's Logs tab is a very useful feature. Especially when an auto-update accidentally breaks something. Allowing for a much quicker review of what has changed and when.

I think it would be a very useful feature to add to update-core.php page.

@knutsp
Copy link
Contributor

knutsp commented Apr 17, 2020

Traditionally WordPress "logs" events by sending an email, as it does when updating in the background.

WordPress has no logging API, for logging types of events, rollover/delete, filter, search etc.

Logging need log management. If not managed, ogging eats disk space and it gets hard to search for specific event.

Maybe log to PHP log, until there is a logging API in core. This will emerge, as WordPress becomes a "web OS" over time.

For now, possibly just save last updated time for each plugin/theme, as an option or long lived transient. If option, even this need to be cleaned up or maintained as sane when deleting a plugin/theme.

@abuyoyo
Copy link
Author

abuyoyo commented Apr 17, 2020

I understand your explanation of why WP does not log (disk space etc.)

I'm not looking for support. I was suggesting a feature that I think is useful.
EUM does the job for me quite nicely. If such a feature is not up for discussion (requiring a new API etc.) then that's that. You may close this.

@pbiron pbiron added the enhancement New feature or request label Apr 17, 2020
@pbiron
Copy link
Contributor

pbiron commented Apr 17, 2020

Such a feature is certainly "up for discussion", but the result of that discussion is likely to be that it is "plugin territory" (i.e., not something that is likely to be included in core as long as core has enough hooks for plugins to implement the feature).

And given that EUM does provide such logging, it seems the proper hooks do exist in core. While I can't speak for the author(s) of EUM (or any other plugin currently provides a UI for controlling auto-updates) I would expect them to continue to provide the features that they provide which go above and beyond what will be in core once this feature plugin is merged (and they may also decide that their UI is better than what we are providing and disable the core UI, which is just fine).

That said, I do think that a logging feature goes beyond the scope of this feature plugin. But I'll leave this issue open for a while to allow discussion.

@ronalfy
Copy link

ronalfy commented Apr 17, 2020

I wrote the logs portion for the advanced and free versions. They’re intense... a lot of moving parts. I no longer work with the company. Just thought I’d try to contribute here with all my lessons learned from EUM. Logs are an absolute feature, so perhaps the folks at EUM will allow me to fork their plugin and release a part of it for free. Just an idea.

Regarding EUM, I imagine they’ll want to have control of if auto-updates on the plugins and themes screen are displayed, that way they use EUM’s interface. I don’t imagine EUM or other well-known update plugins to go away anytime soon and there’s a lot of lessons learned that we can share. For example: what about translations?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants