Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

Plugin/theme auto update already on by earlier filter #6

Open
jeffpaul opened this issue Mar 25, 2020 · 3 comments
Open

Plugin/theme auto update already on by earlier filter #6

jeffpaul opened this issue Mar 25, 2020 · 3 comments
Labels
enhancement New feature or request

Comments

@jeffpaul
Copy link
Member

Migrated from: audrasjb/wp-autoupdates#16
Previously opened by: @knutsp
Original description:

When add_filter( 'auto_update_{plugin|theme}', '__return_true', 1 ); so that $update is already true, wp-autoupdates should leave it as is for backwards compatibility with plugins. This should be detected so that there is no "Enable" action button, and probably no "Disable".

It could be nice to be able to override this by allowing "Disable", though.

I use "Advanced Automatic Updates" by pento and I expect it to still work without intervention and indicated correctly in the plugins list.

@jeffpaul jeffpaul added the enhancement New feature or request label Mar 25, 2020
@jeffpaul
Copy link
Member Author

Previously commented by: @knutsp
Original comment:

"Advanced Automatic Updates" with plugins checked has no effect on the list now. I still think this should show all plugins as enabled, but with no visible disable action, or subsidiarly disable action just to have no effect.

@getsource
Copy link
Member

I'd also like to see the previous filters work as currently expected by users.

A new-for-this-feature filter (or other method) that allows turning on auto-updates for new plugins by default (if this doesn't already exist) would be helpful as well.

@pbiron
Copy link
Contributor

pbiron commented Apr 16, 2020

For context, see audrasjb/wp-autoupdates#10 (comment) (my comment on a PR in the old repo for this feature plugin...that didn't get migrated over to this repo).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants