-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trac:60231 Replace constant ABSPATH . WPINC with BLOCKS_PATH in the require-dynamic-blocks.php #5857
base: trunk
Are you sure you want to change the base?
Trac:60231 Replace constant ABSPATH . WPINC with BLOCKS_PATH in the require-dynamic-blocks.php #5857
Conversation
Hi @vishalkakadiya! 👋 Thank you for your contribution to WordPress! 💖 It looks like this is your first pull request to No one monitors this repository for new pull requests. Pull requests must be attached to a Trac ticket to be considered for inclusion in WordPress Core. To attach a pull request to a Trac ticket, please include the ticket's full URL in your pull request description. Pull requests are never merged on GitHub. The WordPress codebase continues to be managed through the SVN repository that this GitHub repository mirrors. Please feel free to open pull requests to work on any contribution you are making. More information about how GitHub pull requests can be used to contribute to WordPress can be found in this blog post. Please include automated tests. Including tests in your pull request is one way to help your patch be considered faster. To learn about WordPress' test suites, visit the Automated Testing page in the handbook. If you have not had a chance, please review the Contribute with Code page in the WordPress Core Handbook. The Developer Hub also documents the various coding standards that are followed:
Thank you, |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
@@ -50,7 +50,7 @@ ${ staticBlockFolderNames } | |||
.map( toDirectoryName ) | |||
.sort() | |||
// To PHP require_once statement: | |||
.map( dirname => `require_once ABSPATH . WPINC . '/blocks/${ dirname }.php';` ) | |||
.map( dirname => `require_once BLOCKS_PATH . '${ dirname }.php';` ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vishalkakadiya this script use for refresh the packages in Gruntfile.js
. Could you please share steps how anyone test it?
Thanks @vishalkakadiya for the PR! Left one comment.
|
Trac ticket: https://core.trac.wordpress.org/ticket/60231