Add PHPUnit tests for wp_parse_id_list function #5851
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A new PHPUnit test file for the 'wp_parse_id_list' function is introduced. It includes various scenarios ranging from plain numbers, strings with spaces, and HTML to strings with commas. This is crucial to guarantee the function's accurate response to a variety of inputs, enhancing software reliability and stability.
The variable 'list' was renamed to 'input_list' for clarify and a new test case 'dup_id' was added. The new test case will further enhance test coverage by handling an additional scenario where there are duplicate identifiers in the input list.
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
Comment on lines
+25
to
+26
| * @ticket 60218 | ||
| * |
There was a problem hiding this comment.
Suggested change
| * @ticket 60218 | |
| * |
No needs to add @ticket annotation for Data Provider.
| } | ||
|
|
||
| /** | ||
| * data for test_wp_parse_id_list |
There was a problem hiding this comment.
Suggested change
| * data for test_wp_parse_id_list | |
| * Data provider for test_wp_parse_id_list(). |
| * @dataProvider data_wp_parse_id_list | ||
| */ | ||
| public function test_wp_parse_id_list( $input_list, $expected ) { | ||
|
|
|
Thanks for the PR! Merged as part of r57737. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new PHPUnit test file for the 'wp_parse_id_list' function is introduced. It includes various scenarios ranging from plain numbers, strings with spaces, and HTML to strings with commas. This is crucial to guarantee the function's accurate response to a variety of inputs, enhancing software reliability and stability.
Trac ticket: https://core.trac.wordpress.org/ticket/60218