From 5f2238df688c2f1e18dca08c504668e810525146 Mon Sep 17 00:00:00 2001 From: Jonathan Desrosiers Date: Mon, 8 Jan 2024 10:17:51 -0500 Subject: [PATCH 1/7] Checkout older commit for Gutenberg. --- .github/workflows/callable-test-gutenberg-build-process.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/callable-test-gutenberg-build-process.yml b/.github/workflows/callable-test-gutenberg-build-process.yml index ef41cff56ed75..265289676c8d0 100644 --- a/.github/workflows/callable-test-gutenberg-build-process.yml +++ b/.github/workflows/callable-test-gutenberg-build-process.yml @@ -44,6 +44,7 @@ jobs: - name: Checkout repository uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1 with: + ref: 3703528d9dd8ef50b5aca9c077c556f6a0af0648 show-progress: ${{ runner.debug == '1' && 'true' || 'false' }} - name: Checkout Gutenberg plugin From 303deb9067532a563e27f9bc7256e29c90e492ac Mon Sep 17 00:00:00 2001 From: Jonathan Desrosiers Date: Mon, 8 Jan 2024 10:21:08 -0500 Subject: [PATCH 2/7] Use correct workflow for testing. --- .github/workflows/callable-test-gutenberg-build-process.yml | 2 +- .github/workflows/test-build-processes.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/callable-test-gutenberg-build-process.yml b/.github/workflows/callable-test-gutenberg-build-process.yml index 265289676c8d0..a0184627aba04 100644 --- a/.github/workflows/callable-test-gutenberg-build-process.yml +++ b/.github/workflows/callable-test-gutenberg-build-process.yml @@ -44,13 +44,13 @@ jobs: - name: Checkout repository uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1 with: - ref: 3703528d9dd8ef50b5aca9c077c556f6a0af0648 show-progress: ${{ runner.debug == '1' && 'true' || 'false' }} - name: Checkout Gutenberg plugin uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1 with: repository: 'WordPress/gutenberg' + ref: 3703528d9dd8ef50b5aca9c077c556f6a0af0648 path: ${{ env.GUTENBERG_DIRECTORY }} show-progress: ${{ runner.debug == '1' && 'true' || 'false' }} diff --git a/.github/workflows/test-build-processes.yml b/.github/workflows/test-build-processes.yml index 660cfdee81543..9d42839783a74 100644 --- a/.github/workflows/test-build-processes.yml +++ b/.github/workflows/test-build-processes.yml @@ -93,7 +93,7 @@ jobs: # See https://docs.github.com/en/actions/learn-github-actions/contexts#context-availability. test-gutenberg-build-process-macos: name: Gutenberg running from ${{ matrix.directory }} - uses: WordPress/wordpress-develop/.github/workflows/callable-test-gutenberg-build-process.yml@trunk + uses: desrosj/wordpress-develop/.github/workflows/callable-test-gutenberg-build-process.yml@test/gutenberg-changes-failing-build permissions: contents: read if: ${{ github.repository == 'WordPress/wordpress-develop' }} From 20ca92eb7672fa38505d032805b68901057d48d1 Mon Sep 17 00:00:00 2001 From: Jonathan Desrosiers Date: Mon, 8 Jan 2024 10:38:33 -0500 Subject: [PATCH 3/7] Try running on a new MacOS runner with 4 cores. --- .github/workflows/callable-test-gutenberg-build-process.yml | 1 - .github/workflows/test-build-processes.yml | 4 ++-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/.github/workflows/callable-test-gutenberg-build-process.yml b/.github/workflows/callable-test-gutenberg-build-process.yml index a0184627aba04..ef41cff56ed75 100644 --- a/.github/workflows/callable-test-gutenberg-build-process.yml +++ b/.github/workflows/callable-test-gutenberg-build-process.yml @@ -50,7 +50,6 @@ jobs: uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1 with: repository: 'WordPress/gutenberg' - ref: 3703528d9dd8ef50b5aca9c077c556f6a0af0648 path: ${{ env.GUTENBERG_DIRECTORY }} show-progress: ${{ runner.debug == '1' && 'true' || 'false' }} diff --git a/.github/workflows/test-build-processes.yml b/.github/workflows/test-build-processes.yml index 9d42839783a74..2af4c16d6480e 100644 --- a/.github/workflows/test-build-processes.yml +++ b/.github/workflows/test-build-processes.yml @@ -93,14 +93,14 @@ jobs: # See https://docs.github.com/en/actions/learn-github-actions/contexts#context-availability. test-gutenberg-build-process-macos: name: Gutenberg running from ${{ matrix.directory }} - uses: desrosj/wordpress-develop/.github/workflows/callable-test-gutenberg-build-process.yml@test/gutenberg-changes-failing-build + uses: WordPress/wordpress-develop/.github/workflows/callable-test-gutenberg-build-process.yml@trunk permissions: contents: read if: ${{ github.repository == 'WordPress/wordpress-develop' }} strategy: fail-fast: false matrix: - os: [ macos-latest ] + os: [ macos-13 ] directory: [ 'src', 'build' ] with: os: ${{ matrix.os }} From 6a03909e10a5928b94f71b18f012d3265f2927cb Mon Sep 17 00:00:00 2001 From: Jonathan Desrosiers Date: Mon, 8 Jan 2024 10:58:34 -0500 Subject: [PATCH 4/7] Try another older commit. --- .github/workflows/callable-test-gutenberg-build-process.yml | 3 ++- .github/workflows/test-build-processes.yml | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/.github/workflows/callable-test-gutenberg-build-process.yml b/.github/workflows/callable-test-gutenberg-build-process.yml index 0e747a059a93a..ed2d5bf5d9795 100644 --- a/.github/workflows/callable-test-gutenberg-build-process.yml +++ b/.github/workflows/callable-test-gutenberg-build-process.yml @@ -36,7 +36,7 @@ jobs: # - Builds Gutenberg. # - Ensures version-controlled files are not modified or deleted. build-process-tests: - name: Gutenberg running from ${{ inputs.directory }} / ${{ inputs.os == 'macos-latest' && 'MacOS' || inputs.os == 'windows-latest' && 'Windows' || 'Linux' }} + name: Gutenberg running from ${{ inputs.directory }} / ${{ inputs.os == 'macos-13' && 'MacOS 13' || inputs.os == 'windows-latest' && 'Windows' || 'Linux' }} runs-on: ${{ inputs.os }} timeout-minutes: 30 @@ -50,6 +50,7 @@ jobs: uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1 with: repository: 'WordPress/gutenberg' + ref: 1ba116b01f986c5945b40d5eecd77c3bd1159df5 path: ${{ env.GUTENBERG_DIRECTORY }} show-progress: ${{ runner.debug == '1' && 'true' || 'false' }} diff --git a/.github/workflows/test-build-processes.yml b/.github/workflows/test-build-processes.yml index 2af4c16d6480e..0a7b7f13cb589 100644 --- a/.github/workflows/test-build-processes.yml +++ b/.github/workflows/test-build-processes.yml @@ -93,7 +93,7 @@ jobs: # See https://docs.github.com/en/actions/learn-github-actions/contexts#context-availability. test-gutenberg-build-process-macos: name: Gutenberg running from ${{ matrix.directory }} - uses: WordPress/wordpress-develop/.github/workflows/callable-test-gutenberg-build-process.yml@trunk + uses: desrosj/wordpress-develop/.github/workflows/callable-test-gutenberg-build-process.yml@test/gutenberg-changes-failing-build permissions: contents: read if: ${{ github.repository == 'WordPress/wordpress-develop' }} From fdd97ff3df792c9d6fa722086e83964b80933bca Mon Sep 17 00:00:00 2001 From: Jonathan Desrosiers Date: Mon, 8 Jan 2024 11:22:37 -0500 Subject: [PATCH 5/7] Use an even older commit. --- .github/workflows/callable-test-gutenberg-build-process.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/callable-test-gutenberg-build-process.yml b/.github/workflows/callable-test-gutenberg-build-process.yml index ed2d5bf5d9795..e98ace216d8fa 100644 --- a/.github/workflows/callable-test-gutenberg-build-process.yml +++ b/.github/workflows/callable-test-gutenberg-build-process.yml @@ -50,7 +50,7 @@ jobs: uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1 with: repository: 'WordPress/gutenberg' - ref: 1ba116b01f986c5945b40d5eecd77c3bd1159df5 + ref: 71ff85b113634032a21b7f15f7b549db108fcb3a path: ${{ env.GUTENBERG_DIRECTORY }} show-progress: ${{ runner.debug == '1' && 'true' || 'false' }} From 76aa3eb1614a07bc8ef1379efacf024fa09743ac Mon Sep 17 00:00:00 2001 From: Jonathan Desrosiers Date: Mon, 8 Jan 2024 11:27:39 -0500 Subject: [PATCH 6/7] Use version 7.4.0. --- .github/workflows/callable-test-gutenberg-build-process.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/callable-test-gutenberg-build-process.yml b/.github/workflows/callable-test-gutenberg-build-process.yml index e98ace216d8fa..3dc174c64f7d5 100644 --- a/.github/workflows/callable-test-gutenberg-build-process.yml +++ b/.github/workflows/callable-test-gutenberg-build-process.yml @@ -50,7 +50,7 @@ jobs: uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1 with: repository: 'WordPress/gutenberg' - ref: 71ff85b113634032a21b7f15f7b549db108fcb3a + ref: v7.4.0 path: ${{ env.GUTENBERG_DIRECTORY }} show-progress: ${{ runner.debug == '1' && 'true' || 'false' }} From 740a827b1a1f4367582ead2dd3f97b0cc4a1833b Mon Sep 17 00:00:00 2001 From: Jonathan Desrosiers Date: Mon, 8 Jan 2024 11:30:21 -0500 Subject: [PATCH 7/7] Try increasing `max-old-space-size`. --- .github/workflows/callable-test-gutenberg-build-process.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/callable-test-gutenberg-build-process.yml b/.github/workflows/callable-test-gutenberg-build-process.yml index 3dc174c64f7d5..1950010d742af 100644 --- a/.github/workflows/callable-test-gutenberg-build-process.yml +++ b/.github/workflows/callable-test-gutenberg-build-process.yml @@ -20,6 +20,7 @@ on: env: GUTENBERG_DIRECTORY: ${{ inputs.directory == 'build' && 'build' || 'src' }}/wp-content/plugins/gutenberg PUPPETEER_SKIP_DOWNLOAD: ${{ true }} + NODE_OPTIONS: '--max-old-space-size=8192' jobs: # Verifies that installing npm dependencies and building the Gutenberg plugin works as expected. @@ -50,7 +51,6 @@ jobs: uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1 with: repository: 'WordPress/gutenberg' - ref: v7.4.0 path: ${{ env.GUTENBERG_DIRECTORY }} show-progress: ${{ runner.debug == '1' && 'true' || 'false' }}