This repository has been archived by the owner on Nov 18, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 127
Visible gap between the footer and the Newsletter signup pattern #404
Labels
[Type] Bug
An existing feature does not function as intended.
Comments
The problem is that if the top margin is removed from the footers with colored backgrounds, it probably needs to be removed from all footers, and the spacing between the footers and content is going to be affected. |
Correct, the footers should probably have no margin so that this doesn't happen with coloured sections 👍 |
This is affected by the following issue: |
This was referenced Oct 14, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Description
The newsletter signup pattern is placed as the last section in 3 designs:
In the news blog template, and when the two landing pages uses either of the footers that has a solid color background, there is a visible gap between the footer and pattern.
Step-by-step reproduction instructions
Go to Appearance > Editor > Templates and select the Home template.
In the Design panel, select the News blog with featured posts grid, and save.
Confirm that there is a gap between the pattern and footer.
Go back to Templates and select Page.
Replace the default footer with one of the footers that have a solid color background.
Save.
Create a new page. In the pattern selection modal, select "Landing page for Book", and save.
View the footer area of the page on the front.
Repeat for "Landing page for Podcast"
Expected behavior
In my opinion the sections would look better without this gap.
Screenshots

The landing pages with the black footer:
News blog with featured posts grid:

The text was updated successfully, but these errors were encountered: