Skip to content
This repository has been archived by the owner on Nov 18, 2024. It is now read-only.

Visible gap between the footer and the Newsletter signup pattern #404

Closed
carolinan opened this issue Sep 25, 2024 · 5 comments · Fixed by #577
Closed

Visible gap between the footer and the Newsletter signup pattern #404

carolinan opened this issue Sep 25, 2024 · 5 comments · Fixed by #577
Labels
[Type] Bug An existing feature does not function as intended.

Comments

@carolinan
Copy link
Contributor

carolinan commented Sep 25, 2024

Description
The newsletter signup pattern is placed as the last section in 3 designs:

  • News blog with featured posts grid
  • Landing page for Book
  • Landing page for Podcast

In the news blog template, and when the two landing pages uses either of the footers that has a solid color background, there is a visible gap between the footer and pattern.

Step-by-step reproduction instructions
Go to Appearance > Editor > Templates and select the Home template.
In the Design panel, select the News blog with featured posts grid, and save.
Confirm that there is a gap between the pattern and footer.

Go back to Templates and select Page.
Replace the default footer with one of the footers that have a solid color background.
Save.
Create a new page. In the pattern selection modal, select "Landing page for Book", and save.
View the footer area of the page on the front.
Repeat for "Landing page for Podcast"

Expected behavior

In my opinion the sections would look better without this gap.

Screenshots
The landing pages with the black footer:
image

News blog with featured posts grid:
image

@carolinan carolinan added the [Type] Bug An existing feature does not function as intended. label Sep 25, 2024
@alaminfirdows
Copy link
Contributor

template: page-no-title

It comes from .wp-site-blocks. Should we reset the margin like we do for the main section (post content)?

image

@alaminfirdows
Copy link
Contributor

template: page

It includes padding for post content, in addition to the margin from .wp-site-blocks.

image

@carolinan
Copy link
Contributor Author

The problem is that if the top margin is removed from the footers with colored backgrounds, it probably needs to be removed from all footers, and the spacing between the footers and content is going to be affected.
A decision needs to be made about which is preferable.

@carolinan carolinan added the [Status] Needs Design Feedback Needs general design feedback. label Oct 3, 2024
@beafialho
Copy link
Contributor

Correct, the footers should probably have no margin so that this doesn't happen with coloured sections 👍

@carolinan carolinan removed the [Status] Needs Design Feedback Needs general design feedback. label Oct 4, 2024
@carolinan carolinan assigned carolinan and unassigned carolinan Oct 4, 2024
@carolinan
Copy link
Contributor Author

This is affected by the following issue:
There is no way to remove the default top margin on the footer template part, without wrapping the part inside a group or using custom CSS:
WordPress/gutenberg#47637

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
[Type] Bug An existing feature does not function as intended.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants