Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Theme URI and Author URI Page Message Clear #55

Open
kafleg opened this issue Aug 3, 2021 · 3 comments
Open

Make Theme URI and Author URI Page Message Clear #55

kafleg opened this issue Aug 3, 2021 · 3 comments

Comments

@kafleg
Copy link
Member

kafleg commented Aug 3, 2021

Now, the message if the theme URI is invalid. It shows,

Expected to receive a 200 status for https://www.templatesell.com/item/markup-seo-wordpress-blog-theme/. Received 404.
See: https://github.com/WordPress/theme-review-action/blob/trunk/docs/ui-errors.md#page-should-return-200-status

We can change the text or we can link to the updated guidelines.

@carolinan
Copy link
Contributor

Is it the text that is not clear, or is the test wrong?
Was it not a 404? I can tell that it is not a 404 now.

@kafleg
Copy link
Member Author

kafleg commented Aug 6, 2021

For theme authors who know 404 page is not allowed, they can understand it. However, for those who are not familiar with the guidelines, they need a clear message about why the 404 pages in Theme URI and Author URI are not allowed and they need to fix it.

@carolinan
Copy link
Contributor

I think it should be self explanatory that 404 is an error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants