Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback on readme instructions #50

Open
carolinan opened this issue Jul 7, 2021 · 0 comments · May be fixed by #51
Open

Feedback on readme instructions #50

carolinan opened this issue Jul 7, 2021 · 0 comments · May be fixed by #51

Comments

@carolinan
Copy link
Contributor

In the instructions for running the tool locally, at the end, it says:
The tests run on files within the /test-theme folder.

This needs to be listed as an action before Run npm run start. because it is easy to miss.

It needs to be clearer that the theme files needs to be placed directly in the test-theme folder:
theme-review-action/test-theme/functions.php
not theme-review-action/test-theme/twentytwentyone/functions.php

-Is there anything preventing this folder from existing when you clone the tool?
Why does the test-theme folder need to be created manually, when the folder is required?

Or is this a situation where it only needs to be created manually on Windows because of #18 ?

@StevenDufresne StevenDufresne linked a pull request Jul 12, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant